GNOME Bugzilla – Bug 760027
[API] value, tag lists, caps: add pretty serialization
Last modified: 2018-11-03 12:31:50 UTC
Serialized caps or tags can at times be very very long if they contain large buffers, e.g. if streamheaders include coverart. It would be nice if we had API for 'pretty' serialization of values, tags, caps, structures, etc, so we can use shortened versions in more places including logs and dot files.
Created attachment 318068 [details] [review] value: add serialize_full() API Adds two features on top of the existing gst_value_serialize(): - serialization into a provided GString (useful for GstCaps, GstStructure and GstTagList serialization) - allows for 'pretty' serialization for display purposes, in which case the string may not always be deserializable again. This is useful when serializing caps or taglists containing huge buffers, which we don't always want to print out or log in full. API: gst_value_serialize_full API: gst_value_serialize_into
Created attachment 318069 [details] [review] value: use GString when serializing flag set This will come in handy later.
Created attachment 318070 [details] [review] value: implement serialize_full function for most common types
Created attachment 318071 [details] [review] caps, structure, taglist: add _to_pretty_string() variants Add _to_pretty_string() variants of caps/structure/taglist to_string() functions. These will return a string for display that might not be abbreviated or not escaped and thus can't be deserialized again. Helps serializing caps or taglists that contain large buffers, the exact content of which is often not that important. Also add gst_structure_serialize_into() which is useful when serializing caps. API: gst_structure_serialize_into API: gst_structure_to_pretty_string API: gst_tag_list_to_pretty_string API: gst_caps_to_pretty_string
Created attachment 318072 [details] [review] value: add support for pretty serialization of caps and taglists
Created attachment 318073 [details] [review] gstobject: use pretty serialisation in default deep-notify handler This is used to print caps and properties with gst-launch-1.0 -v
Created attachment 318074 [details] [review] tools: gst-launch: use pretty serialization when printing tags
Created attachment 318075 [details] [review] info: use pretty printing functions where applicable
Created attachment 318076 [details] [review] debugutils: use pretty caps serialization in dot files
Created attachment 318077 [details] [review] value: improve buffer serialisation Avoid merging of memories in case the buffer is made up of multiple memories.
Instead of serialization (is it deserializeable without information loss?) I would probably call that pretty printing or something similar. Otherwise a very good idea :)
Well, I initially thought I'd make it a GstValueGetDisplayString function or somesuch, but I thought a SerializeFull() that allows extensability with other flags in future is more useful.
> Well, I initially thought I'd make it a GstValueGetDisplayString function or > somesuch, but I thought a SerializeFull() that allows extensability with > other flags in future is more useful. Oh, and there is also the added benefit that it can be used by the existing code when it does not do pretty printing, so GstCaps serialisation can be done directly into one GString also for the non-pretty case.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/148.