GNOME Bugzilla – Bug 759989
Add GNetworkMonitor support for win32
Last modified: 2018-01-17 12:53:51 UTC
Created attachment 318019 [details] win32 impl of GNetworkMonitor The GNetworkMonitor system doesn't currently support win32 network monitoring, the attached has been taken from Pidgin and ported to the GNetworkMonitor object as Pidgin is planning on using GNetworkMonitor in an upcoming first I've also backported it to load as a module since we're only going to use it with gio 2.32
Created attachment 318020 [details] header of win32 impl of GNetworkMonitor
I'm not a maintainer on this stuff, so take my comments with a grain of salt. Sorry the bug has sat here for so long. I'm not sure what happened with that other than win32 things do not get a lot of eyeballs. I know that pidgin has a different coding style than glib, but when presenting code for inclusion please format it to match the codebase at hand. Also, this appears to have #ifdef's to aid in backporting for Pidgin. This, of course, makes sense for an application, but for something intended to land in glib this stuff should be removed to ease the reviewers lives. Our reviewers go through an incredible amount of patches, and those with the lowest barrier to review generally get reviewed first. Also, the attachements are just uploaded files. Please submit a patch from a git commit (so you get proper attribution) as well as updating the build system to build the included files. I'm not sure if the other backends have unit tests, but if they do, we should try to provide something similar. Hope that helps you move forward.
A different version of this has been committed in bug #685442. *** This bug has been marked as a duplicate of bug 685442 ***