After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759983 - [ods] t6514 fails by dropping rich text font size
[ods] t6514 fails by dropping rich text font size
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export OOo / OASIS
git master
Other All
: Normal normal
: ---
Assigned To: Andreas J. Guelzow
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2015-12-30 00:28 UTC by Morten Welinder
Modified: 2015-12-31 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2015-12-30 00:28:13 UTC 
t6514-rich-text.pl: Check rich text ods roundtrip.
--- rich-text-tests.xml	2015-12-29 19:27:10.416378322 -0500
+++ rich-text-tests-new.xml	2015-12-29 19:27:10.420378322 -0500
@@ -153,7 +153,7 @@
         <gnm:Cell Row="10" Col="0" ValueType="60">Strikethrough</gnm:Cell>
         <gnm:Cell Row="10" Col="1" ValueType="60" ValueFormat="@[strikethrough=1:1:4]">Sample text</gnm:Cell>
         <gnm:Cell Row="11" Col="0" ValueType="60">Font size</gnm:Cell>
-        <gnm:Cell Row="11" Col="1" ValueType="60" ValueFormat="@[size=20480:1:6]">Sample text</gnm:Cell>
+        <gnm:Cell Row="11" Col="1" ValueType="60">Sample text</gnm:Cell>
         <gnm:Cell Row="13" Col="0" ValueType="60">Non-shared</gnm:Cell>
         <gnm:Cell Row="13" Col="1" ValueType="60" ValueFormat="@[strikethrough=1:0:4]">richpoor text</gnm:Cell>
         <gnm:Cell Row="15" Col="0" ValueType="60">Comment</gnm:Cell>
diff died due to signal 1
Comment 1 Andreas J. Guelzow 2015-12-30 03:52:22 UTC 
We aren't writing the size info:
        <table:table-row table:style-name="AROW-5">
          <table:table-cell table:style-name="ACE-0" office:value-type="string"><text:p>Font size</text:p></table:table-cell>
          <table:table-cell table:style-name="ACE-0" office:value-type="string"><text:p>Sample text</text:p></table:table-cell>
          <table:table-cell table:number-columns-repeated="254" table:style-name="ACE-0"/>
        </table:table-row>

Testing with an LO generated file that contains size info shows that we are not reading it either.
Comment 2 Andreas J. Guelzow 2015-12-30 04:40:15 UTC 
We are now reading the font size.
Comment 3 Andreas J. Guelzow 2015-12-30 05:25:48 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 4 Morten Welinder 2015-12-30 20:51:11 UTC 
Great, although I wish we could avoid such a fixed-sized table on export.
Comment 5 Andreas J. Guelzow 2015-12-31 08:38:24 UTC 
We now avoid that long listing of automatic styles by just writing the needed font size styles as named styles to styles.xml.