After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759857 - Signal name should not be translated
Signal name should not be translated
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-25 09:58 UTC by Marek Černocký
Modified: 2015-12-25 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GdkSeat: Use g_intern_static_string() for signal names (1.18 KB, patch)
2015-12-25 13:27 UTC, Carlos Garnacho 		committed Details | Review

Description Marek Černocký 2015-12-25 09:58:17 UTC 
Signal names are marked with P_ for translation in gdk/gdkseat.c

g_signal_new (P_("device-added"),
              G_TYPE_FROM_CLASS (klass),
              G_SIGNAL_RUN_LAST,
              G_STRUCT_OFFSET (GdkSeatClass, device_added),
              NULL, NULL,
              g_cclosure_marshal_VOID__OBJECT,
              G_TYPE_NONE, 1,
              GDK_TYPE_DEVICE);

g_signal_new (P_("device-removed"),
              G_TYPE_FROM_CLASS (klass),
              G_SIGNAL_RUN_LAST,
              G_STRUCT_OFFSET (GdkSeatClass, device_removed),
              NULL, NULL,
              g_cclosure_marshal_VOID__OBJECT,
              G_TYPE_NONE, 1,
              GDK_TYPE_DEVICE);
Comment 1 Carlos Garnacho 2015-12-25 13:27:12 UTC 
Spectacular thinko. Thanks for spotting.
Comment 2 Carlos Garnacho 2015-12-25 13:27:52 UTC 
The following fix has been pushed:
9290aa7 GdkSeat: Use g_intern_static_string() for signal names
Comment 3 Carlos Garnacho 2015-12-25 13:27:56 UTC 
Created attachment 317874 [details] [review]
GdkSeat: Use g_intern_static_string() for signal names