After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759824 - build: Use symlinks for nmtui
build: Use symlinks for nmtui
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmtui
1.0.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-23 23:57 UTC by Michael Biebl
Modified: 2016-01-07 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] build: Use symlinks for nmtui (990 bytes, patch)
2015-12-23 23:57 UTC, Michael Biebl 		none Details | Review

Description Michael Biebl 2015-12-23 23:57:00 UTC 
Created attachment 317834 [details] [review]
[PATCH] build: Use symlinks for nmtui

Make /usr/bin/nmtui-* symbolic links to /usr/bin/nmtui.

Using symlinks makes it simpler to spot then hard links.

Also, when building the package on Debian, the package uses DESTDIR= as part of the build process and then copies the files into the final binary packages. Using hard links results in file copies, i.e. wastes disk space.


I've been shipping that patch for a while in Debian and would like to see it go upstream.
Comment 1 Thomas Haller 2016-01-04 19:21:52 UTC 
lgtm. But I forgot why they are symlinks in the first place.

danw, do you know?
Comment 2 Michael Biebl 2016-01-04 19:37:15 UTC 
(In reply to Thomas Haller from comment #1)
> lgtm. But I forgot why they are symlinks in the first place.

I guess you mean "hard links"?
Comment 3 Dan Winship 2016-01-04 19:45:41 UTC 
(In reply to Thomas Haller from comment #1)
> lgtm. But I forgot why they are [hard links] in the first place.

There was no reason. That's how I happened to write it, and later when someone (actually, Michael I think) suggested we should use symlinks instead, I checked what other packages did, and found little consistency, so we left it as it was.

Though, scanning /bin now, it does look like there are more symlinks than hard links.
Comment 4 Beniamino Galvani 2016-01-07 16:34:57 UTC 
If there aren't other constraints, maybe I prefer symlinks over hard links because it's more explicit from a 'ls' that they point to the same file. So patch LGTM.