After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759785 - GdkSeat: Suspected errors in documentation
GdkSeat: Suspected errors in documentation
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Class: GdkDevice
3.19.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
Carlos Garnacho
Depends on:
Blocks: 759806
 
 
Reported: 2015-12-22 18:38 UTC by Kjell Ahlstedt
Modified: 2018-04-15 00:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kjell Ahlstedt 2015-12-22 18:38:08 UTC
gdk_seat_grab():
The description of @owner_events has been copied verbatim from
gdk_device_grab(). It mentions @event_mask, but gdk_seat_grab() has no such
parameter. It has @event.
I guess that more than just the parameter name should be changed in the
description.

gdk_seat_get_slaves():
The description of the return value says (element-type GdkSeat).
Shouldn't it be (element-type GdkDevice)?

gdk_device_manager_list_devices():
Deprecated. gdk_seat_list_slaves() is listed as one of the replacements, but
in GdkSeat the function is called gdk_seat_get_slaves().

gdk_device_manager_get_client_pointer():
Deprecated, with no replacement. Would it be correct to list
gdk_seat_get_pointer() as a replacement?
Comment 1 Kjell Ahlstedt 2015-12-29 17:21:07 UTC
gdk_seat_get_slaves() does return a list of GdkDevice's. It would be fine to
have a confirmation that that's the intention. Preferably by a fixed
documentation.
Comment 2 Kjell Ahlstedt 2016-01-02 10:40:14 UTC
Added Carlos Garnacho to the CC list. He wrote the GdkSeat class, and is
probably best suited to answer my questions.
Comment 3 Matthias Clasen 2016-01-11 20:11:48 UTC
Fixed all except for the first one
Comment 4 Matthias Clasen 2016-02-21 05:38:23 UTC
Carlos, can you look at the owner_events docs ?
Comment 5 Matthias Clasen 2018-02-10 05:02:03 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 6 Kjell Ahlstedt 2018-02-14 17:31:46 UTC
Most of the issues in the bug description have been fixed. The only remaining
issue is the first one, the description of @owner_events in gdk_seat_grab().
It's not important to me. I don't mind if this bug is closed.
Comment 7 Matthias Clasen 2018-04-15 00:16:32 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new