After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759700 - Fix deprecated file creation mode mask
Fix deprecated file creation mode mask
Status: RESOLVED FIXED
Product: gnome-sound-recorder
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-sound-recorder maintainer(s)
gnome-sound-recorder maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-20 14:50 UTC by Miguel Vaello Martínez
Modified: 2015-12-28 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mask patch (1008 bytes, patch)
2015-12-20 14:53 UTC, Miguel Vaello Martínez
none Details | Review

Description Miguel Vaello Martínez 2015-12-20 14:50:54 UTC
I was inspecting the trace and I found the following warning message:

´´´
Gjs-Message: JS WARNING: [resource:///org/gnome/SoundRecorder/js/application.js 96]: octal literals and octal escape sequences are deprecated
´´´
As the trace says, the common way to set octal masks are deprecated and should be replaced.

The attached patch fixes the issue by parsing the octal mask (as string) using parseInt() function.
Comment 1 Miguel Vaello Martínez 2015-12-20 14:53:05 UTC
Created attachment 317692 [details] [review]
Mask patch
Comment 2 Meg Ford 2015-12-28 22:12:46 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.


Thanks for the patch! Fix committed here:
https://git.gnome.org/browse/gnome-sound-recorder/commit/