After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759665 - Update mail ops after change in libcamel
Update mail ops after change in libcamel
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.19.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 759716 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-12-19 15:35 UTC by Emmanuele Bassi (:ebassi)
Modified: 2016-01-11 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update mail ops after change in libcamel (2.59 KB, patch)
2015-12-19 15:57 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2015-12-19 15:35:45 UTC
The following commit in evolution-data-server broke the Evolution build:

https://git.gnome.org/browse/evolution-data-server/commit/?id=a06c602777c34e9da55d7b8361605a908d74e1ce

with the following error:

../../libemail-engine/mail-ops.c: In function 'mail_fetch_mail':
../../libemail-engine/mail-ops.c:526:52: warning: passing argument 2 of 'camel_filter_driver_set_status_func' from incompatible pointer type
   camel_filter_driver_set_status_func (fm->driver, status, status_data);
                                                    ^
In file included from /usr/include/evolution-data-server/camel/camel-session.h:29:0,
                 from /usr/include/evolution-data-server/camel/camel-cipher-context.h:28,
                 from /usr/include/evolution-data-server/camel/camel.h:30,
                 from /usr/include/evolution-data-server/libedataserver/e-source-camel.h:25,
                 from /usr/include/evolution-data-server/libedataserver/libedataserver.h:52,
                 from ../../libemail-engine/mail-ops.c:36:
/usr/include/evolution-data-server/camel/camel-filter-driver.h:92:6: note: expected 'CamelFilterStatusFunc' but argument is of type 'void (**)(struct CamelFilterDriver *, enum camel_filter_status_t,  gint,  const gchar *, void *)'
 void camel_filter_driver_set_status_func      (CamelFilterDriver *d, CamelFilterStatusFunc func, gpointer data);
      ^
../../libemail-engine/mail-ops.c: In function 'report_status':
../../libemail-engine/mail-ops.c:935:3: error: called object is not a function or function pointer
   m->status (m->driver, status, pc, str, m->status_data);
   ^
Makefile:793: recipe for target 'libemail_engine_la-mail-ops.lo' failed
Comment 1 Emmanuele Bassi (:ebassi) 2015-12-19 15:57:58 UTC
Created attachment 317669 [details] [review]
Update mail ops after change in libcamel

Commit a06c602777c34e9da55d7b8361605a908d74e1ce in e-d-s changed the
typedef of various delegate functions, and it broke the build of
Evolution.
Comment 2 Emmanuele Bassi (:ebassi) 2015-12-19 16:45:52 UTC
I've tagged evolution-data-server in GNOME Continuous; will revert once Evolution gets fixed.
Comment 3 Milan Crha 2016-01-11 18:12:59 UTC
*** Bug 759716 has been marked as a duplicate of this bug. ***
Comment 4 Milan Crha 2016-01-11 18:42:16 UTC
Thanks for a bug report and a patch. Weird, I'm pretty sure I tried the build of all the evolution parts, but I didn't face the issue. I do face it too now. To be on a safe side I bumped the libcamel soname version within bug #759214 and committed your fix.

Created commit 46b706c in evo master (3.19.4+)