After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759600 - decklinkvideosink: Made "auto" mode work according to caps
decklinkvideosink: Made "auto" mode work according to caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-17 15:30 UTC by Vivia Nikolaidou
Modified: 2015-12-18 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (untested) (3.90 KB, patch)
2015-12-17 15:31 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2015-12-17 15:30:36 UTC
When the mode of decklinkvideosink is set to "auto", the sink claims to
support the full set of caps that it can support for all modes. Then, every
time new caps are set, the sink will automatically find the correct mode for
these caps and set it.

Caveat: We have no way to know whether a specific mode will actually work for
your hardware. Therefore, if you try sending 4K video to a 1080 screen, it
will silently fail, we have no way to know that in advance. Manually setting
that mode at least gave the user a way to double-check what they are doing.
Comment 1 Vivia Nikolaidou 2015-12-17 15:31:42 UTC
Created attachment 317577 [details] [review]
Patch (untested)

Patch file. Untested so far, but it "should" work (famous last words). I can test it myself on Monday, but if someone else wants to test it before that, please do so.
Comment 2 Vivia Nikolaidou 2015-12-18 14:58:16 UTC
A colleague of mine (Georg Lippitsch)  tested the patch and found it to work. Quoting him: "Tested with several different resolutions and frame rates, the output mode is now set automatically without the need to set sdi-decklink-mode explicitly."
Comment 3 Sebastian Dröge (slomo) 2015-12-18 15:09:14 UTC
commit fafc8e564c59141c6f3bafa104f81bd6b56f1a46
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Thu Dec 17 17:26:29 2015 +0200

    decklinkvideosink: Made "auto" mode work according to caps
    
    When the mode of decklinkvideosink is set to "auto", the sink claims to
    support the full set of caps that it can support for all modes. Then, every
    time new caps are set, the sink will automatically find the correct mode for
    these caps and set it.
    
    Caveat: We have no way to know whether a specific mode will actually work for
    your hardware. Therefore, if you try sending 4K video to a 1080 screen, it
    will silently fail, we have no way to know that in advance. Manually setting
    that mode at least gave the user a way to double-check what they are doing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759600