After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759586 - Add a way to highlight resizing widgets
Add a way to highlight resizing widgets
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-17 12:06 UTC by Timm Bäder
Modified: 2015-12-18 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (6.29 KB, patch)
2015-12-17 12:06 UTC, Timm Bäder
none Details | Review
Add a way to highlight resizing widgets (6.67 KB, patch)
2015-12-18 14:57 UTC, Timm Bäder
accepted-commit_now Details | Review

Description Timm Bäder 2015-12-17 12:06:05 UTC
Created attachment 317557 [details] [review]
Proposed patch

Yup, patch adds a new debug flag as well as a switch in the inspector.
Comment 1 Matthias Clasen 2015-12-17 13:45:58 UTC
For new debug flags at least, we should make sure to tie them to the display so the inspector is not affected by them.
Comment 2 Timm Bäder 2015-12-18 09:45:54 UTC
(In reply to Matthias Clasen from comment #1)
> For new debug flags at least, we should make sure to tie them to the display
> so the inspector is not affected by them.

Makes sense. Is there an example I could follow?
Comment 3 Matthias Clasen 2015-12-18 11:31:41 UTC
(In reply to Timm Bäder from comment #2)
> (In reply to Matthias Clasen from comment #1)
> > For new debug flags at least, we should make sure to tie them to the display
> > so the inspector is not affected by them.
> 
> Makes sense. Is there an example I could follow?

No. I quickly tried implementing gtk_{get,set}_display_debug_flags() yesterday and came away unconvinced. Maybe gtk_{get,set}_window_debug_flags() would be better.

Anyway, lets not block this useful feature on that. Anything we come up with will work for all of these debug flags anyway.
Comment 4 Matthias Clasen 2015-12-18 11:31:54 UTC
Review of attachment 317557 [details] [review]:

You also need to add an entry for this new flag to gtk_debug_keys in gtkmain.c

::: gtk/gtkdebug.h
@@ +56,3 @@
   GTK_DEBUG_TOUCHSCREEN     = 1 << 18,
+  GTK_DEBUG_ACTIONS         = 1 << 19,
+  GTK_DEBUG_WIDGET_RESIZE_HIGHLIGHT = 1 << 20

I would shorten this to GTK_DEBUG_RESIZE
Comment 5 Timm Bäder 2015-12-18 14:57:18 UTC
Created attachment 317631 [details] [review]
Add a way to highlight resizing widgets
Comment 6 Matthias Clasen 2015-12-18 15:10:13 UTC
Review of attachment 317631 [details] [review]:

Getting there. Please document the new GTK_DEBUG option in docs/reference/gtk/running.sgml. Fine to commit with the docs
Comment 7 Timm Bäder 2015-12-18 15:54:17 UTC
Pushed, thanks.