GNOME Bugzilla – Bug 759586
Add a way to highlight resizing widgets
Last modified: 2015-12-18 15:54:17 UTC
Created attachment 317557 [details] [review] Proposed patch Yup, patch adds a new debug flag as well as a switch in the inspector.
For new debug flags at least, we should make sure to tie them to the display so the inspector is not affected by them.
(In reply to Matthias Clasen from comment #1) > For new debug flags at least, we should make sure to tie them to the display > so the inspector is not affected by them. Makes sense. Is there an example I could follow?
(In reply to Timm Bäder from comment #2) > (In reply to Matthias Clasen from comment #1) > > For new debug flags at least, we should make sure to tie them to the display > > so the inspector is not affected by them. > > Makes sense. Is there an example I could follow? No. I quickly tried implementing gtk_{get,set}_display_debug_flags() yesterday and came away unconvinced. Maybe gtk_{get,set}_window_debug_flags() would be better. Anyway, lets not block this useful feature on that. Anything we come up with will work for all of these debug flags anyway.
Review of attachment 317557 [details] [review]: You also need to add an entry for this new flag to gtk_debug_keys in gtkmain.c ::: gtk/gtkdebug.h @@ +56,3 @@ GTK_DEBUG_TOUCHSCREEN = 1 << 18, + GTK_DEBUG_ACTIONS = 1 << 19, + GTK_DEBUG_WIDGET_RESIZE_HIGHLIGHT = 1 << 20 I would shorten this to GTK_DEBUG_RESIZE
Created attachment 317631 [details] [review] Add a way to highlight resizing widgets
Review of attachment 317631 [details] [review]: Getting there. Please document the new GTK_DEBUG option in docs/reference/gtk/running.sgml. Fine to commit with the docs
Pushed, thanks.