GNOME Bugzilla – Bug 759548
Shortcuts window - various small issues
Last modified: 2018-05-24 11:07:12 UTC
Small issues I can see: * The playback section is rather long. * It is hard to understand the "go to" items - you have to do a bit of arithmetic to realise how each of the time spans relate to one another. * It isn't clear what "Skip to dialog" means. I actually had to try the shortcut to figure it out.
Created attachment 317500 [details] [review] patch
Review of attachment 317500 [details] [review]: It's better to split those sort of patches. You can use "git add -p" or "git commit -p" to only add a portion of a file to the commit. The section split is fine, but the adjectives use, is less so. We'll need to find a better way to do this, either: <- skip back -> skip fwd ctrl+-> / ctrl+<- skip further shift+<- / shift+<- skip closer or use the same unit for each one and group back and forward shortcuts and sort them in growing interval.
Created attachment 317555 [details] [review] data: Split "Skipping" and "Playback" shortcut sections
Comment on attachment 317555 [details] [review] data: Split "Skipping" and "Playback" shortcut sections Attachment 317555 [details] pushed as edd99ea - data: Split "Skipping" and "Playback" shortcut sections
(In reply to Bastien Nocera from comment #2) > Review of attachment 317500 [details] [review] [review]: > > It's better to split those sort of patches. You can use "git add -p" or "git > commit -p" to only add a portion of a file to the commit. > > The section split is fine, That's done in the separate patch, and merged.
Created attachment 317565 [details] [review] patchclearer label for skip to dialog Patch for the "skip to dialog" label.
Created attachment 317566 [details] [review] patch: easier labels for skip actions Trying a different formulation for the skip action labels here. Not sure if it's quite good enough, but better than what I had before.
Review of attachment 317565 [details] [review]: Looks good, though the commit subject should be: data: Clearer label for "skip to" dialog shortcut
Review of attachment 317566 [details] [review]: Still don't really like this, there's no information as to the order of magnitude of the jumps, and I'll get asked that... Would it be better if I re-ordered the items in increasing "jump" lengths, and used the same unit (seconds) for all the labels?
Comment on attachment 317565 [details] [review] patchclearer label for skip to dialog Committed: https://git.gnome.org/browse/totem/commit/?id=019685928e25d6134d5b678d44b2b2f49ae478b1
(In reply to Bastien Nocera from comment #9) > Review of attachment 317566 [details] [review] [review]: > > Still don't really like this, there's no information as to the order of > magnitude of the jumps, and I'll get asked that... I'm not sure how interesting that information is, tbh. You could add it in brackets after the label, I suppose. > Would it be better if I re-ordered the items in increasing "jump" lengths, > and used the same unit (seconds) for all the labels? The problem there is that the default action is in the middle, so you're still left with some figuring out to do: Shift + ← Go back 5 seconds ← Go back 15 seconds Ctrl + ← Go back 180 seconds
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/totem/issues/155.