After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759541 - shortcuts: Make sure that hidden shortcuts stay hidden
shortcuts: Make sure that hidden shortcuts stay hidden
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-16 11:23 UTC by Bastien Nocera
Modified: 2015-12-16 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shortcuts: Make sure that hidden shortcuts stay hidden (1.35 KB, patch)
2015-12-16 11:23 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2015-12-16 11:23:41 UTC 
.
Comment 1 Bastien Nocera 2015-12-16 11:23:48 UTC 
Created attachment 317493 [details] [review]
shortcuts: Make sure that hidden shortcuts stay hidden

When doing a gtk_widget_show_all() on the shortcuts window,
accelerators for both RTL and LTR directions are being shown.

Make sure that no-show-all is set by default on hidden shortcuts, and
updated if the widget direction changes.
Comment 2 Matthias Clasen 2015-12-16 11:26:43 UTC 
Review of attachment 317493 [details] [review]:

yeah, looks right. We need more than that if we want to make GtkShortcutsWindow safe against show_all, but this is a good start
Comment 3 Bastien Nocera 2015-12-16 11:32:48 UTC 
(In reply to Matthias Clasen from comment #2)
> Review of attachment 317493 [details] [review] [review]:
> 
> yeah, looks right. We need more than that if we want to make
> GtkShortcutsWindow safe against show_all, but this is a good start

There's already plenty of "no-show-all" in the GtkShortcutsShortcut, so that part looked safe.
Comment 4 Bastien Nocera 2015-12-16 11:33:25 UTC 
Attachment 317493 [details] pushed as a56a8a8 - shortcuts: Make sure that hidden shortcuts stay hidden