After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759501 - Since epiphany 3.19.1, some "normal" content is blocked and crashes epiphany when the inspector is open
Since epiphany 3.19.1, some "normal" content is blocked and crashes epiphany ...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 760206 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-12-15 16:04 UTC by Guillaume Ayoub
Modified: 2016-01-07 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revert "EphyUriTester: Drop keys/signatures logic" (7.35 KB, patch)
2015-12-18 15:54 UTC, Michael Catanzaro
committed Details | Review

Description Guillaume Ayoub 2015-12-15 16:04:41 UTC
Since 3.19.1, some content is blocked by the ad blocker with no appearant reason, as it's not blocked by other ad-blockers (including AdBlock) on other browsers. Moreover, it leads to really incoherent and erratic behaviours depending on how you ask to reach the page.

I suppose that it's related to #754954.

Here is a example with simple steps:

1. create "/tmp/test.html" with this HTML: '<img src="file:///tmp/static/administration.png">'
2. create an image and call it /tmp/static/administration.png
3. type "epiphany /tmp/test.html" on a terminal: the image is drawn
4. refresh the page with F5: the image is hidden
5. de-activate the ad-blocker and refresh: the image is drawn
6. re-activate the ad-blocker and refresh: the image is hidden
5. open a new tab and reach "file:///tmp/test.html": the image is hidden
6. open the web inspector and refresh the page: the rendering crashes

These problems happen with HTTP too (they are not related to file://). The pattern matched here by the ad-blocker seems to be "*static/administration*".

I don't get this behaviour (or the inspector crash) with pages whose advertisements were also blocked with 3.18.x.
Comment 1 Michael Catanzaro 2015-12-15 18:02:25 UTC
Hm, we made several changes to the adblocker between 3.18.0 and 3.18.1. Exactly which version did you test with -- 3.18.0, 3.18.1, or 3.18.2? This could help with pinpointing the regression.
Comment 2 Michael Catanzaro 2015-12-15 18:03:27 UTC
Also, please include the WebKitGTK+ versions that you're testing each version with (check them in the About dialog) so we can be sure this is a regression in Epiphany and not in WebKit.
Comment 3 Guillaume Ayoub 2015-12-15 23:10:05 UTC
Thanks a lot for your quick answer and for your hard work on Epiphany.

With WebKit 2.11.1:
- Epiphany 3.18.0 works.
- Epiphany 3.18.1, 3.18.2 and 3.19.1 don't.
Comment 4 Guillaume Ayoub 2015-12-15 23:43:43 UTC
I've git-bissected, the culprit commit is d694e8 (EphyUriTester: Drop keys/signatures logic).
Comment 5 Michael Catanzaro 2015-12-16 13:31:19 UTC
Emanuele, any chance you'll be able to look into this?
Comment 6 Michael Catanzaro 2015-12-18 15:54:47 UTC
The following fix has been pushed:
04a4224 Revert "EphyUriTester: Drop keys/signatures logic"
Comment 7 Michael Catanzaro 2015-12-18 15:54:50 UTC
Created attachment 317634 [details] [review]
Revert "EphyUriTester: Drop keys/signatures logic"

This reverts commit 1600a5fb51f43b7969782c096c62c54f336d5571.
Comment 8 Guillaume Ayoub 2015-12-18 17:08:06 UTC
It works, thank you!
Comment 9 Michael Catanzaro 2016-01-07 16:00:32 UTC
*** Bug 760206 has been marked as a duplicate of this bug. ***