After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759482 - go to line command breaks j
go to line command breaks j
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-15 10:28 UTC by misko.herko
Modified: 2015-12-15 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (805 bytes, patch)
2015-12-15 10:28 UTC, misko.herko
accepted-commit_now Details | Review

Description misko.herko 2015-12-15 10:28:04 UTC
Created attachment 317408 [details] [review]
fix

how to reproduce:
enable vim key bindings, open long file
go to line 1 with gg
use :123<enter> to navigate to line 123
type j
expected:
go to the line 124
actual:
go to the line 246
Comment 1 sébastien lafargue 2015-12-15 18:03:27 UTC
hi, which version ?

work in master as we reset the counter:

https://git.gnome.org/browse/gnome-builder/tree/data/keybindings/vim.css#n233
Comment 2 misko.herko 2015-12-15 19:24:29 UTC
The bug is in master.
please note the ":".
the bug is triggered when entering line number in command bar.
Comment 3 sébastien lafargue 2015-12-15 19:45:05 UTC
right, got it
Comment 4 sébastien lafargue 2015-12-15 19:45:27 UTC
Review of attachment 317408 [details] [review]:

LGTM