GNOME Bugzilla – Bug 759462
osm login dialog is too tall
Last modified: 2018-01-22 21:12:57 UTC
Created attachment 317387 [details] screenshot there is this gap at the bottom of the dialog. Not sure where it comes from.
Created attachment 317603 [details] [review] Reduced overall height of osm-account-dialog box
Created attachment 317604 [details] Screenshot of above mentioned change
Review of attachment 317603 [details] [review]: Thanks for this! See the guide about commit message from other review! I think maybe: "osm-account-dialog: Decrease height" And again no need to specify what files were altered. Otherwise it looks fine I think. Andreas, does this meet your expectations?
Comment on attachment 317603 [details] [review] Reduced overall height of osm-account-dialog box >From 0bd923f155c432fbaf0b1d901b7a705f46331a25 Mon Sep 17 00:00:00 2001 >From: Karanbir Chahal <karanbleep@gmail.com> >Date: Fri, 18 Dec 2015 10:56:15 +0530 >Subject: [PATCH 1/1] osm-account-dialog: Decrease height > >The previous height of the osm dialog box was 250 px which led to a lot of wasted space.This commit reduces it to 150 px . > > https://bugzilla.gnome.org/show_bug.cgi?id=759462 >--- > data/ui/osm-account-dialog.ui | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/data/ui/osm-account-dialog.ui b/data/ui/osm-account-dialog.ui >index 48a7f51..9173ad8 100644 >--- a/data/ui/osm-account-dialog.ui >+++ b/data/ui/osm-account-dialog.ui >@@ -190,7 +190,7 @@ OpenStreetMap account.</property> > <property name="visible">True</property> > <property name="halign">GTK_ALIGN_FILL</property> > <property name="self-scrolling">True</property> >- <property name="height-request">250</property> >+ <property name="height-request">150</property> > </object> > <packing> > <property name="left_attach">0</property> >-- >2.5.0 >
Created attachment 317627 [details] [review] Updated patch with changes mentioned
Review of attachment 317627 [details] [review]: The commit body seem to have to long lines.
Review of attachment 317627 [details] [review]: Could maybe split the commit body message with a newline after the first sentence. Might maybe spell out the pixels, as well. Also, did you test this to see that the verification frame loads and is visible after signing in with the user name and password? Looks good otherwise!
Created attachment 317647 [details] verification screenshot
Created attachment 317648 [details] signed in screenshot It's still very tall once you're signed in, and once you've signed out, it stays the taller height.
Created attachment 317649 [details] screenshot of signed out again
(In reply to Marcus Lundblad from comment #7) > Review of attachment 317627 [details] [review] [review]: > Also, did you test this to see that the verification frame loads and is > visible after signing in with the user name and password? See sreenshot in comment 8
Hmm yeah , it goes back to that 250 pixels and stays that way unless you close it and open it again. Any suggestions?
Changing the height to 150 pixels worked fine.
Created attachment 367237 [details] osm login dialog box height is 150 pixels
Created attachment 367238 [details] after logging in the height looks fine after login
Created attachment 367239 [details] log out screenshot this is after I logged out of my osm account
Created attachment 367240 [details] [review] osmAccountDialog: Decrease height of log in dialog changed height from 250 pixels to 150 pixels
Review of attachment 367240 [details] [review]: LGTM
Thanks!
Attachment 367240 [details] pushed as e70b6df - osmAccountDialog: Decrease height of log in dialog