After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759460 - Shortcuts window improvements
Shortcuts window improvements
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.19.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-14 16:56 UTC by Allan Day
Modified: 2016-02-14 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.99 KB, patch)
2015-12-14 16:58 UTC, Allan Day 		committed Details | Review
help-overlay: Various improvements (4.55 KB, patch)
2016-02-14 20:28 UTC, Debarshi Ray 		committed Details | Review

Description Allan Day 2015-12-14 16:56:25 UTC 
A few things could be improved with the shortcuts window: how to use delete in the overview isn't clear, and the general section includes shortcuts that don't work everywhere.
Comment 1 Allan Day 2015-12-14 16:58:29 UTC 
Created attachment 317384 [details] [review]
patch
Comment 2 Debarshi Ray 2016-01-27 11:04:03 UTC 
Review of attachment 317384 [details] [review]:

Thanks for the patch, Allan! A few quick questions:

::: src/photos-help-overlay.ui
@@ +110,3 @@
+                <property name="accelerator">Delete</property>
+              </object>
+            </child>

Shouldn't we also have a "Print selected photo" entry in the Overview group? It is possible to print from the selection.

@@ +130,3 @@
+                <property name="accelerator">Delete</property>
+              </object>
+            </child>

A general question. I guess you don't want to use the "<Action> the current photo" terminology, right? I am asking because now that we have Edit and Export shortcuts, we should tweak them too.

Also, I guess, Edit and Export should be listed above Print and Delete because they are going to be more commonly used. Right?
Comment 3 Debarshi Ray 2016-02-14 20:28:27 UTC 
Created attachment 321157 [details] [review]
help-overlay: Various improvements

Made the above adjustments, rebased and pushed.