After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759432 - bad plugins: Fix example pipelines
bad plugins: Fix example pipelines
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-14 02:10 UTC by Vineeth
Modified: 2015-12-15 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix example pipelines (1.40 KB, patch)
2015-12-14 02:11 UTC, Vineeth
none Details | Review
Fix example pipelines for bad plugins (17.48 KB, application/gzip)
2015-12-15 04:12 UTC, Vineeth
  Details

Description Vineeth 2015-12-14 02:10:22 UTC
Fix example pipelines.
gst-launch --> gst-launch-1.0
Comment 1 Vineeth 2015-12-14 02:11:22 UTC
Created attachment 317327 [details] [review]
fix example pipelines
Comment 2 Luis de Bethencourt 2015-12-14 10:39:55 UTC
Hi Vineeth,

There are hundreds of examples using gst-launch (instead of gst-launch-1.0) across just gstreamer core, gstreamer-plugins-base and gst-plugins-good. I don't think we are inclined to change those.

If the change was from gst-launch-0.10 (which is deprecated upstream) I would merge your change. I understand the logic of your proposal, but in my opinion "gst-launch" is easy enough to understand since the trailing "-1.0" will be autocompleted by any modern shell.

Leaving the bug open for a little while in case other people want to join and give their opinion.
Comment 3 Vineeth 2015-12-14 11:19:29 UTC
Hi Luis
Generally i tend to just copy paste the example pipeline. So everytime i copy paste have to change it to 1.0 :).. guess every does the same..

I do understand it just means same.. but some extra work after copy pasting :)..

Maybe instead of seperate patches for each element, we can just make changes for all elements together..
Or no need to :D
Comment 4 Tim-Philipp Müller 2015-12-14 11:38:40 UTC
I have actually fixed this in all modules but -bad.

I think the pipelines should be updated to use gst-launch-1.0, but at the same time they need to be checked for old caps, old elements, etc.

I would welcome a patch that fixes up all the pipelines (or at least all in ext/, gst/ or sys/) in the element doc blurbs :)
Comment 5 Luis de Bethencourt 2015-12-14 11:51:43 UTC
Nice.

Vineeth, are you interested in doing this across all gst-plugins-bad as one big patch? Let us know and if you aren't I can do it myself.
Comment 6 Vineeth 2015-12-14 12:02:26 UTC
I will be able to do it tomorrow :)
Comment 7 Luis de Bethencourt 2015-12-14 14:38:37 UTC
Great! Thanks Vineeth
Comment 8 Vineeth 2015-12-15 04:12:12 UTC
Created attachment 317400 [details]
Fix example pipelines for bad plugins

Fixed only for the elements ported to 1.0 and compiling.
Some problem with uploading patch. So compressing and attaching the patch file
Comment 9 Luis de Bethencourt 2015-12-15 10:34:26 UTC
Please send as patch file in the future and not a tarball.

Thanks for this :)


commit 7c42ba97d7ca394c0a2db097a65d3a895f6b5605
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Mon Dec 14 11:09:46 2015 +0900

    plugins-bad: Fix example pipelines

    rename gst-launch --> gst-launch-1.0
    replace old elements with new elements(ffmpegcolorspace -> videoconvert, ffenc_** -> avenc_**)
    fix caps in examples

    https://bugzilla.gnome.org/show_bug.cgi?id=759432
Comment 10 Tim-Philipp Müller 2015-12-15 10:55:15 UTC
nice work, thanks!