After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759401 - [PATCHes] Kill g_object_class_install_property.
[PATCHes] Kill g_object_class_install_property.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-13 10:01 UTC by Arnaud B.
Modified: 2015-12-16 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
EphyEncodingDialog: Use g_object_class_install_properties. (2.05 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyWindowAction: Remove some trailing spaces. (1.93 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyCompletionModel: Use g_object_class_install_properties. (3.79 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyWindowAction: Use g_object_class_install_properties. (1.87 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyLocationController: Use g_object_class_install_properties. (6.23 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyLocationController: Remove trailing spaces. (2.66 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyWebView: Use g_object_class_install_properties. (15.36 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyNodeDb: Spaces problems. (1.35 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphyNodeDb: Use g_object_class_install_properties. (2.47 KB, patch)
2015-12-13 10:05 UTC, Arnaud B.
committed Details | Review
EphySQLiteStatement: Use g_object_class_install_properties. (2.96 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyNotebook: Use g_object_class_install_properties. (1.78 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphySession: Use g_object_class_install_properties. (2.42 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyNavigationHistoryAction: Use g_object_class_install_properties. (1.80 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyCombinedStopReloadAction: Use g_object_class_install_properties. (1.90 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyHistoryWindow: Use g_object_class_install_properties. (1.92 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyTopicsPalette: Use g_object_class_install_properties. (2.78 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyTopicsPalette: Correct trailing spaces. (4.79 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyTopicsEntry: Correct trailing spaces. (11.30 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyTopicsEntry: Use g_object_class_install_properties. (2.25 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyTopicAction: Use g_object_class_install_properties. (2.62 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyBookmarksEditor: Use g_object_class_install_properties. (1.81 KB, patch)
2015-12-13 10:06 UTC, Arnaud B.
committed Details | Review
EphyBookmarkProperties: Use g_object_class_install_properties. (2.90 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyBookmarkAction: Remove trailing spaces. (2.68 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyBookmarkAction: Use g_object_class_install_properties. (4.86 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyZoomAction: Use g_object_class_install_properties. (1.94 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphySecurityPopover: Use g_object_class_install_properties. (5.49 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyTreeModelNode: Use g_object_class_install_properties. (1.58 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyNodeView: Use g_object_class_install_properties. (2.22 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyNodeView: Remove trailing spaces. (5.78 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyDownloadWidget: Use g_object_class_install_properties. (2.19 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyLocationEntry: Use g_object_class_install_properties. (3.74 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyLocationEntry: Remove trailing spaces. (6.67 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyCertificateDialog: Use g_object_class_install_properties. (4.49 KB, patch)
2015-12-13 10:07 UTC, Arnaud B.
committed Details | Review
EphyHistoryService: Remove trailing spaces. (4.28 KB, patch)
2015-12-13 10:08 UTC, Arnaud B.
committed Details | Review
EphyHistoryService: Use g_object_class_install_properties. (3.26 KB, patch)
2015-12-13 10:08 UTC, Arnaud B.
committed Details | Review

Description Arnaud B. 2015-12-13 10:01:16 UTC
We should use g_object_class_install_properties instead.

I didn’t do src/ephy-window.c, because of a strange g_object_class_override_property function that I don’t know much about.

After this patchset, there’s some remaining "g_object_notify " function in src/ephy-window.c and in src/ephy-shell-search-provider-generated.c only… looks good?

I’m trying `git bz` for the first time, so let me apologize for all the things I might break during the process.
Comment 1 Arnaud B. 2015-12-13 10:05:15 UTC
Created attachment 317265 [details] [review]
EphyEncodingDialog: Use g_object_class_install_properties.
Comment 2 Arnaud B. 2015-12-13 10:05:20 UTC
Created attachment 317266 [details] [review]
EphyWindowAction: Remove some trailing spaces.
Comment 3 Arnaud B. 2015-12-13 10:05:25 UTC
Created attachment 317267 [details] [review]
EphyCompletionModel: Use g_object_class_install_properties.
Comment 4 Arnaud B. 2015-12-13 10:05:30 UTC
Created attachment 317268 [details] [review]
EphyWindowAction: Use g_object_class_install_properties.
Comment 5 Arnaud B. 2015-12-13 10:05:35 UTC
Created attachment 317269 [details] [review]
EphyLocationController: Use g_object_class_install_properties.
Comment 6 Arnaud B. 2015-12-13 10:05:40 UTC
Created attachment 317270 [details] [review]
EphyLocationController: Remove trailing spaces.
Comment 7 Arnaud B. 2015-12-13 10:05:45 UTC
Created attachment 317271 [details] [review]
EphyWebView: Use g_object_class_install_properties.
Comment 8 Arnaud B. 2015-12-13 10:05:50 UTC
Created attachment 317272 [details] [review]
EphyNodeDb: Spaces problems.
Comment 9 Arnaud B. 2015-12-13 10:05:55 UTC
Created attachment 317273 [details] [review]
EphyNodeDb: Use g_object_class_install_properties.
Comment 10 Arnaud B. 2015-12-13 10:06:00 UTC
Created attachment 317274 [details] [review]
EphySQLiteStatement: Use g_object_class_install_properties.
Comment 11 Arnaud B. 2015-12-13 10:06:05 UTC
Created attachment 317275 [details] [review]
EphyNotebook: Use g_object_class_install_properties.
Comment 12 Arnaud B. 2015-12-13 10:06:10 UTC
Created attachment 317276 [details] [review]
EphySession: Use g_object_class_install_properties.
Comment 13 Arnaud B. 2015-12-13 10:06:15 UTC
Created attachment 317277 [details] [review]
EphyNavigationHistoryAction: Use g_object_class_install_properties.
Comment 14 Arnaud B. 2015-12-13 10:06:20 UTC
Created attachment 317278 [details] [review]
EphyCombinedStopReloadAction: Use g_object_class_install_properties.
Comment 15 Arnaud B. 2015-12-13 10:06:26 UTC
Created attachment 317279 [details] [review]
EphyHistoryWindow: Use g_object_class_install_properties.
Comment 16 Arnaud B. 2015-12-13 10:06:31 UTC
Created attachment 317280 [details] [review]
EphyTopicsPalette: Use g_object_class_install_properties.
Comment 17 Arnaud B. 2015-12-13 10:06:36 UTC
Created attachment 317281 [details] [review]
EphyTopicsPalette: Correct trailing spaces.
Comment 18 Arnaud B. 2015-12-13 10:06:41 UTC
Created attachment 317282 [details] [review]
EphyTopicsEntry: Correct trailing spaces.
Comment 19 Arnaud B. 2015-12-13 10:06:46 UTC
Created attachment 317283 [details] [review]
EphyTopicsEntry: Use g_object_class_install_properties.
Comment 20 Arnaud B. 2015-12-13 10:06:51 UTC
Created attachment 317284 [details] [review]
EphyTopicAction: Use g_object_class_install_properties.
Comment 21 Arnaud B. 2015-12-13 10:06:57 UTC
Created attachment 317285 [details] [review]
EphyBookmarksEditor: Use g_object_class_install_properties.
Comment 22 Arnaud B. 2015-12-13 10:07:01 UTC
Created attachment 317286 [details] [review]
EphyBookmarkProperties: Use g_object_class_install_properties.
Comment 23 Arnaud B. 2015-12-13 10:07:06 UTC
Created attachment 317287 [details] [review]
EphyBookmarkAction: Remove trailing spaces.
Comment 24 Arnaud B. 2015-12-13 10:07:12 UTC
Created attachment 317288 [details] [review]
EphyBookmarkAction: Use g_object_class_install_properties.
Comment 25 Arnaud B. 2015-12-13 10:07:17 UTC
Created attachment 317289 [details] [review]
EphyZoomAction: Use g_object_class_install_properties.
Comment 26 Arnaud B. 2015-12-13 10:07:22 UTC
Created attachment 317290 [details] [review]
EphySecurityPopover: Use g_object_class_install_properties.
Comment 27 Arnaud B. 2015-12-13 10:07:27 UTC
Created attachment 317291 [details] [review]
EphyTreeModelNode: Use g_object_class_install_properties.
Comment 28 Arnaud B. 2015-12-13 10:07:32 UTC
Created attachment 317292 [details] [review]
EphyNodeView: Use g_object_class_install_properties.
Comment 29 Arnaud B. 2015-12-13 10:07:38 UTC
Created attachment 317293 [details] [review]
EphyNodeView: Remove trailing spaces.
Comment 30 Arnaud B. 2015-12-13 10:07:42 UTC
Created attachment 317294 [details] [review]
EphyDownloadWidget: Use g_object_class_install_properties.
Comment 31 Arnaud B. 2015-12-13 10:07:47 UTC
Created attachment 317295 [details] [review]
EphyLocationEntry: Use g_object_class_install_properties.
Comment 32 Arnaud B. 2015-12-13 10:07:53 UTC
Created attachment 317296 [details] [review]
EphyLocationEntry: Remove trailing spaces.
Comment 33 Arnaud B. 2015-12-13 10:07:58 UTC
Created attachment 317297 [details] [review]
EphyCertificateDialog: Use g_object_class_install_properties.
Comment 34 Arnaud B. 2015-12-13 10:08:03 UTC
Created attachment 317298 [details] [review]
EphyHistoryService: Remove trailing spaces.
Comment 35 Arnaud B. 2015-12-13 10:08:09 UTC
Created attachment 317299 [details] [review]
EphyHistoryService: Use g_object_class_install_properties.
Comment 36 Michael Catanzaro 2015-12-16 12:58:24 UTC
Thanks
Comment 37 Michael Catanzaro 2015-12-16 13:08:15 UTC
Attachment 317265 [details] pushed as 4b49613 - EphyEncodingDialog: Use g_object_class_install_properties.
Attachment 317266 [details] pushed as 36aa6ec - EphyWindowAction: Remove some trailing spaces.
Attachment 317267 [details] pushed as 15f4d31 - EphyCompletionModel: Use g_object_class_install_properties.
Attachment 317268 [details] pushed as df9c8a0 - EphyWindowAction: Use g_object_class_install_properties.
Attachment 317269 [details] pushed as 5f79e98 - EphyLocationController: Use g_object_class_install_properties.
Attachment 317270 [details] pushed as 9cf3e5a - EphyLocationController: Remove trailing spaces.
Attachment 317271 [details] pushed as 42c9e4d - EphyWebView: Use g_object_class_install_properties.
Attachment 317272 [details] pushed as 08a2598 - EphyNodeDb: Spaces problems.
Attachment 317273 [details] pushed as 6876602 - EphyNodeDb: Use g_object_class_install_properties.
Attachment 317274 [details] pushed as 39e56d5 - EphySQLiteStatement: Use g_object_class_install_properties.
Attachment 317275 [details] pushed as 468d6b2 - EphyNotebook: Use g_object_class_install_properties.
Attachment 317276 [details] pushed as 100849b - EphySession: Use g_object_class_install_properties.
Attachment 317277 [details] pushed as 437270d - EphyNavigationHistoryAction: Use g_object_class_install_properties.
Attachment 317278 [details] pushed as 627cfa1 - EphyCombinedStopReloadAction: Use g_object_class_install_properties.
Attachment 317279 [details] pushed as 253de7c - EphyHistoryWindow: Use g_object_class_install_properties.
Attachment 317280 [details] pushed as e4ebb84 - EphyTopicsPalette: Use g_object_class_install_properties.
Attachment 317281 [details] pushed as fc25b8d - EphyTopicsPalette: Correct trailing spaces.
Attachment 317282 [details] pushed as 01c107c - EphyTopicsEntry: Correct trailing spaces.
Attachment 317283 [details] pushed as 75e952f - EphyTopicsEntry: Use g_object_class_install_properties.
Attachment 317284 [details] pushed as fba43d4 - EphyTopicAction: Use g_object_class_install_properties.
Attachment 317285 [details] pushed as d1fe748 - EphyBookmarksEditor: Use g_object_class_install_properties.
Attachment 317286 [details] pushed as 079e04c - EphyBookmarkProperties: Use g_object_class_install_properties.
Attachment 317287 [details] pushed as d31cdf1 - EphyBookmarkAction: Remove trailing spaces.
Attachment 317288 [details] pushed as 464efbc - EphyBookmarkAction: Use g_object_class_install_properties.
Attachment 317289 [details] pushed as e71369c - EphyZoomAction: Use g_object_class_install_properties.
Attachment 317290 [details] pushed as 6d4ea49 - EphySecurityPopover: Use g_object_class_install_properties.
Attachment 317291 [details] pushed as f7736a8 - EphyTreeModelNode: Use g_object_class_install_properties.
Attachment 317292 [details] pushed as 8992380 - EphyNodeView: Use g_object_class_install_properties.
Attachment 317293 [details] pushed as 0a54916 - EphyNodeView: Remove trailing spaces.
Attachment 317294 [details] pushed as 1f43e26 - EphyDownloadWidget: Use g_object_class_install_properties.
Attachment 317295 [details] pushed as c5df941 - EphyLocationEntry: Use g_object_class_install_properties.
Attachment 317296 [details] pushed as d52c5d9 - EphyLocationEntry: Remove trailing spaces.
Attachment 317297 [details] pushed as 04739e1 - EphyCertificateDialog: Use g_object_class_install_properties.
Attachment 317298 [details] pushed as 936cb64 - EphyHistoryService: Remove trailing spaces.
Attachment 317299 [details] pushed as efc19dc - EphyHistoryService: Use g_object_class_install_properties.