After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759379 - Show sendToDialog even if browser has no icon
Show sendToDialog even if browser has no icon
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-12 00:06 UTC by Hashem Nasarat
Modified: 2015-12-13 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show sendToDialog even if browser has no icon (1.17 KB, patch)
2015-12-12 00:06 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2015-12-12 00:06:35 UTC 
My default browser doesn't have an icon.
get_icon() can return null and this raised an unhandled error which
prevented the sendToDialog from showing.
Comment 1 Hashem Nasarat 2015-12-12 00:06:39 UTC 
Created attachment 317243 [details] [review]
Show sendToDialog even if browser has no icon
Comment 2 Jonas Danielsson 2015-12-12 15:29:21 UTC 
Review of attachment 317243 [details] [review]:

Thanks alot Hashem!

The patch looks great!
Comment 3 Jonas Danielsson 2015-12-12 15:30:06 UTC 
Attachment 317243 [details] pushed as 2219112 - Show sendToDialog even if browser has no icon
Comment 4 Jonas Danielsson 2015-12-13 19:16:53 UTC 
Also, fyi: I will receive a mail about all bugs filed in the gnome-maps bugzilla so you only need to ping me on IRC if you fear I have forgotten :)

If you want to follow Maps, then you can add:
gnome-maps-maint@gnome.bugs

under user you want to watch in bugzilla, you go to "preferences" then "email preferences"