After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759366 - Bookmarking behaves strangely
Bookmarking behaves strangely
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.18.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-11 18:28 UTC by Alessandro Bono
Modified: 2016-06-05 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
preview: Fix bookmark action (2.68 KB, patch)
2016-04-24 23:12 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2015-12-11 18:28:52 UTC 
If you mark a page and then go to the next pages, the bookmark's button is still pressed. The same happens if you go to the previous pages.
The button isn't pressed anymore if you go to the marked page for the second time (eg: press next two times then press previous three times).
Comment 1 Alessandro Bono 2016-04-24 23:12:34 UTC 
Created attachment 326647 [details] [review]
preview: Fix bookmark action

If a handler is connected to GSimpleAction::change-state it
must implement the actual action change. Connect to
GActionGroup:action-state-changed as done for the others
stateful actions.

Source: https://developer.gnome.org/gio/stable/GSimpleAction.html#GSimpleAction-change-state
Comment 2 Bastien Nocera 2016-06-05 12:57:07 UTC 
Review of attachment 326647 [details] [review]:

Looks correct, should go into gnome-3-20 and master.
Comment 3 Alessandro Bono 2016-06-05 16:16:31 UTC 
Attachment 326647 [details] pushed as d06589b - preview: Fix bookmark action