After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759314 - GNOME Continuous build failure due to debugging code
GNOME Continuous build failure due to debugging code
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-10 18:32 UTC by Emmanuele Bassi (:ebassi)
Modified: 2015-12-10 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emmanuele Bassi (:ebassi) 2015-12-10 18:32:48 UTC
The debugging code:

  vte_debug_print (...)

expands to:

  if (condition)
    ...

This means that code that depends on VTE_DEBUG being defined will still get compiled. For instance, the newly added to_string() methods exist only if VTE_DEBUG is defined, but debugging printouts still call them.

This breaks the compilation of VTE on GNOME Continuous:

../../src/vte.cc: In member function 'void VteTerminalPrivate::invalidate_match_span()':
../../src/vte.cc:5764:71: error: 'struct vte::grid::span' has no member named 'to_string'
                          "Invalidating match span %s\n", m_match_span.to_string());
                                                                       ^
../../src/debug.h:87:56: note: in definition of macro '_vte_debug_print'
  G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
                                                        ^
../../src/vte.cc: In member function 'void VteTerminalPrivate::match_hilite_update(long int, long int)':
../../src/vte.cc:5852:35: error: 'struct vte::grid::span' has no member named 'to_string'
     "Matched %s.\n", m_match_span.to_string());
                                   ^
../../src/debug.h:87:56: note: in definition of macro '_vte_debug_print'
  G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
                                                        ^
../../src/vte.cc:5857:67: error: 'struct vte::grid::span' has no member named 'to_string'
                                  "No matches %s.\n", m_match_span.to_string());
                                                                   ^
../../src/debug.h:87:56: note: in definition of macro '_vte_debug_print'
  G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
Comment 1 Emmanuele Bassi (:ebassi) 2015-12-10 18:35:12 UTC
I've tagged VTE in GNOME Continuous. Please revert commit a410ad53fce5eb92837933e7446802096b2122ac when this bug is closed.
Comment 2 Christian Persch 2015-12-10 20:09:48 UTC
Should be fixed on master.