GNOME Bugzilla – Bug 759306
rtpbin: request pads from GstRtpSession only if they do not exist
Last modified: 2015-12-11 13:10:02 UTC
Created attachment 317123 [details] [review] rtpbin: request pads from GstRtpSession only if they do not exist If a pad is already created, gst_element_get_request_pad fails.
When exactly would it happen that this code is called although the pad exists already?
For example, if you add a probe to a pad of the GstRtpSession before request a new pad for the RtpBin.
What part of that would request a pad twice then?
In my case, I request the pad "recv_rtp_src" of the GstRtpSession, and when I request the "recv_rtp_src_%u" pad of the RtpBin, it requests the "recv_rtp_src" pad again.
Well, that's wrong. You must not request pads from the rtpsession yourself if it is to be managed by rtpbin.
I see your point, but I need to do more things related with the GstRtpSession pads. Do you see if this patch could cause any kind of problem?
It causes inconsistencies with internal assumptions of rtpbin, I don't think we want to make this a supported use case. Why can't you request the pad via rtpbin, and then later add your probes to the rtpsession pads?
Yes, it is another alternative, although I though that this eased the development. Anyway, I will requests pads via RtpBin. Thanks ;).
The main problem I see with supporting what you're doing is, that once we support it we have to support it forever. And it might make implementing future features more tricky, or we could easily break it by some change because it's not how anybody else is using rtpbin. Let's close this then
OK