After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759293 - rtpbin: add "get-session" property
rtpbin: add "get-session" property
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other Linux
: Normal enhancement
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-12-10 11:14 UTC by Miguel París Díaz
Modified: 2016-02-16 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

rtpbin: add "get-session" property (2.96 KB, patch)
2015-12-10 11:14 UTC, Miguel París Díaz
none Details | Review
rtpbin: add "get-session" property (2.96 KB, patch)
2015-12-10 11:17 UTC, Miguel París Díaz
none Details | Review
rtpbin: add "get-session" signal (2.91 KB, patch)
2015-12-10 11:29 UTC, Miguel París Díaz
none Details | Review
rtpbin: add "get-session" signal (3.00 KB, patch)
2015-12-10 15:04 UTC, Miguel París Díaz
committed Details | Review

Description Miguel París Díaz 2015-12-10 11:14:31 UTC
Created attachment 317096 [details] [review]
rtpbin: add "get-session" property

RtpBin does not have any way of getting the GstRtpSession related with an id.
With this patch I add this feature.
Comment 1 Miguel París Díaz 2015-12-10 11:17:28 UTC
Created attachment 317097 [details] [review]
rtpbin: add "get-session" property
Comment 2 Sebastian Dröge (slomo) 2015-12-10 11:21:00 UTC
It would probably make sense to just give proper names to the rtpsession elements inside the rtpbin, e.g. naming them session_%u.

What do you need the rtpsession element for?
Comment 3 Sebastian Dröge (slomo) 2015-12-10 11:21:40 UTC
Comment on attachment 317097 [details] [review]
rtpbin: add "get-session" property

We don't do this "Change-Id" stuff and also you added a signal, not a property :)
Comment 4 Miguel París Díaz 2015-12-10 11:26:42 UTC
My architecture fits more managing each GstRtpSession individually, instead of having a ref to the RtpBin.
With this I can manage in the same way GstRtpSessions that are and aren't into an RtpBin.
Comment 5 Miguel París Díaz 2015-12-10 11:28:25 UTC
Oh, sorry I am removing the Change-Id and changing the commit msg
Comment 6 Miguel París Díaz 2015-12-10 11:29:29 UTC
Created attachment 317099 [details] [review]
rtpbin: add "get-session" signal
Comment 7 Miguel París Díaz 2015-12-10 14:38:47 UTC
There is a bug, I am fixing it.
Comment 8 Miguel París Díaz 2015-12-10 15:04:22 UTC
Created attachment 317121 [details] [review]
rtpbin: add "get-session" signal
Comment 9 Sebastian Dröge (slomo) 2015-12-11 08:20:10 UTC
Comment on attachment 317121 [details] [review]
rtpbin: add "get-session" signal

Ok, but why not just name the elements properly and then use gst_bin_get_by_name()?
Comment 10 Miguel París Díaz 2015-12-11 09:32:41 UTC
Well, this could be another solution, but the "get-session" one matches better with the current "API" ("get-internal-session").
Moreover, I prefer having unique names in the whole pipeline. I mean that if you have more than one RtpBin, you will have RtpSessions with the same name, which is tricky for debugging.
Comment 11 Miguel París Díaz 2015-12-14 14:26:19 UTC
@slomo, what do you think about accept this patch as is?
Comment 12 Sebastian Dröge (slomo) 2015-12-14 14:57:47 UTC
I'm waiting if someone else has opinions
Comment 13 Miguel París Díaz 2016-01-11 12:50:39 UTC
Hello Sebastian,
first of all, happy new year!! ;)

There is not any opinion in one month, could we accept the patch?
Comment 14 Sebastian Dröge (slomo) 2016-02-16 11:42:39 UTC
commit 92affe2dec1446c38ae65cf3c8f03363009c22fe
Author: Miguel París Díaz <>
Date:   Thu Dec 10 12:15:52 2015 +0100

    rtpbin: add "get-session" signal
    This gets the GstRTPSession element, as compared to the RTPSession object
    that is returned by get-internal-session.