GNOME Bugzilla – Bug 759293
rtpbin: add "get-session" property
Last modified: 2016-02-16 11:42:39 UTC
Created attachment 317096 [details] [review] rtpbin: add "get-session" property RtpBin does not have any way of getting the GstRtpSession related with an id. With this patch I add this feature.
Created attachment 317097 [details] [review] rtpbin: add "get-session" property
It would probably make sense to just give proper names to the rtpsession elements inside the rtpbin, e.g. naming them session_%u. What do you need the rtpsession element for?
Comment on attachment 317097 [details] [review] rtpbin: add "get-session" property We don't do this "Change-Id" stuff and also you added a signal, not a property :)
My architecture fits more managing each GstRtpSession individually, instead of having a ref to the RtpBin. With this I can manage in the same way GstRtpSessions that are and aren't into an RtpBin.
Oh, sorry I am removing the Change-Id and changing the commit msg
Created attachment 317099 [details] [review] rtpbin: add "get-session" signal
There is a bug, I am fixing it.
Created attachment 317121 [details] [review] rtpbin: add "get-session" signal
Comment on attachment 317121 [details] [review] rtpbin: add "get-session" signal Ok, but why not just name the elements properly and then use gst_bin_get_by_name()?
Well, this could be another solution, but the "get-session" one matches better with the current "API" ("get-internal-session"). Moreover, I prefer having unique names in the whole pipeline. I mean that if you have more than one RtpBin, you will have RtpSessions with the same name, which is tricky for debugging.
@slomo, what do you think about accept this patch as is?
I'm waiting if someone else has opinions
Hello Sebastian, first of all, happy new year!! ;) There is not any opinion in one month, could we accept the patch?
commit 92affe2dec1446c38ae65cf3c8f03363009c22fe Author: Miguel París Díaz <mparisdiaz@gmail.com> Date: Thu Dec 10 12:15:52 2015 +0100 rtpbin: add "get-session" signal This gets the GstRTPSession element, as compared to the RTPSession object that is returned by get-internal-session. https://bugzilla.gnome.org/show_bug.cgi?id=759293