After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759260 - [Adwaita:dark] menus on GtkTreeView barely visible because menu shadows are understated
[Adwaita:dark] menus on GtkTreeView barely visible because menu shadows are u...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.18.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-09 16:38 UTC by Christian Stadelmann
Modified: 2015-12-11 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Stadelmann 2015-12-09 16:38:41 UTC
In Adwaita:light theme, menus can easily be distinguished from whatever they are drawn on. Menus have clearly visible dark shadows.

In Adwaita:dark theme menus have the same dark shadows as in Adwaita:light. Since the background those shadows are drawn upon is dark too, those shadows can barely be recognized. Especially with menus drawn over GtkTreeViews or GtkTextViews those shadows are barely visible and thus borders can barely be recognized.

When looking at CSD menus this is just a minor issue since their background color is lighter so there is a visible contrast between menu and menu border.
Comment 1 Lapo Calamandrei 2015-12-09 17:47:26 UTC
True, the menus are hard to see on the dark variant, I'd rather change make menus background the same color of popovers though.
Comment 2 Lapo Calamandrei 2015-12-09 18:09:01 UTC
Thanks for reporting, fixed in both master branch and 3.18 branch
Comment 3 Michael Catanzaro 2015-12-11 10:29:54 UTC
I don't think this should have been changed in the 3.18 branch; we don't want menu colors to change on users mid-release (at least not with the light theme).
Comment 4 Lapo Calamandrei 2015-12-11 16:30:21 UTC
Considering that menus are pretty much a marginal widget nowadays and we're speaking about going from a white to a light gray BG, I don't consider this a big change, I can revert anyway if you really think it's a problem.
Comment 5 Lapo Calamandrei 2015-12-11 19:14:03 UTC
Ouch, I didn't consider combobox entries or similar widgets, Michael you're right, restricting the change to dark variant, where it's badly needed.