GNOME Bugzilla – Bug 759248
preview: Fix possible warnings exiting fullscreen
Last modified: 2016-01-04 00:48:47 UTC
Reproducer in the commit description.
Created attachment 317024 [details] [review] preview: Fix possible warnings exiting fullscreen After opening a document, turning on the fullscreen mode, and starting a search (type a few letters), you'll get warnings from EvView when "Esc" is pressed. This is caused by the search being reset when exiting the preview. As we don't have a document, or document model anymore, there's no search to be done.
Review of attachment 317024 [details] [review]: Wouldn't it be possible to avoid the 'updated' signal to be emitted at all (i.e. cancel/destroy the EvJobFind) when the model is unset?
Created attachment 317094 [details] [review] preview: Fix possible warnings exiting fullscreen After opening a document, turning on the fullscreen mode, and starting a search (type a few letters), you'll get warnings from EvView when "Esc" is pressed. This is caused by the search being reset when exiting the preview. As we don't have a document, or document model anymore, there's no search to be done.
(In reply to Cosimo Cecchi from comment #2) > Review of attachment 317024 [details] [review] [review]: > > Wouldn't it be possible to avoid the 'updated' signal to be emitted at all > (i.e. cancel/destroy the EvJobFind) when the model is unset? Good call, I did that when the model is being reset.
Review of attachment 317094 [details] [review]: Thanks, looks good, but it also contains an update to the libgd submodule which shouldn't be here AFAICT.
Created attachment 317198 [details] [review] preview: Fix possible warnings exiting fullscreen After opening a document, turning on the fullscreen mode, and starting a search (type a few letters), you'll get warnings from EvView when "Esc" is pressed. This is caused by the search being reset when exiting the preview. As we don't have a document, or document model anymore, there's no search to be done.
Attachment 317198 [details] pushed as cd6d7c7 - preview: Fix possible warnings exiting fullscreen
If you open a document and go back without searching, it complains about a null reference. (org.gnome.Documents:29808): Gjs-WARNING **: JS ERROR: Exception in callback for signal: window-mode-changed: TypeError: this._jobFind is null PreviewView<.setModel@resource:///org/gnome/Documents/js/preview.js:572
Created attachment 318180 [details] [review] preview: Check if this._jobFind is null Fallout from cd6d7c76ddf063fe0f285044c06ced0ce45e97d7
Review of attachment 318180 [details] [review]: Looks good, thanks.
Attachment 318180 [details] pushed as f5b2047 - preview: Check if this._jobFind is null