After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759235 - g_hash_table_resize(): epiphany killed by SIGABRT
g_hash_table_resize(): epiphany killed by SIGABRT
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.18.x (obsolete)
Other Linux
: Normal critical
: ---
Assigned To: Claudio Saavedra
Epiphany Maintainers
: 759234 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-12-09 11:28 UTC by Michael Catanzaro
Modified: 2016-03-01 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
snapshot-service: do not update cache table from other threads (3.63 KB, patch)
2015-12-09 12:22 UTC, Claudio Saavedra 		committed Details | Review

Description Michael Catanzaro 2015-12-09 11:28:07 UTC 
Crash in the snapshot service

Version-Release number of selected component:
epiphany-runtime-3.16.2-2.fc22

Additional info:
reporter:       libreport-2.6.0
backtrace_rating: 4
cmdline:        epiphany
crash_function: g_hash_table_resize
executable:     /usr/bin/epiphany
global_pid:     4520
kernel:         4.0.6-300.fc22.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (7 frames)
 #7 g_hash_table_resize at ghash.c:616
 #8 g_hash_table_maybe_resize at ghash.c:645
 #9 g_hash_table_insert_node at ghash.c:978
 #10 g_hash_table_insert_internal at ghash.c:1228
 #11 save_snapshot_thread at ephy-snapshot-service.c:634
 #12 g_task_thread_pool_thread at gtask.c:1231
 #14 g_thread_proxy at gthread.c:764

See the downstream bug in the See Also field for a full backtrace.
Comment 1 Claudio Saavedra 2015-12-09 12:22:50 UTC 
Created attachment 317015 [details] [review]
snapshot-service: do not update cache table from other threads

GLib hash tables are not thread-safe. Use a idle function to
update the cache from the main thread.
Comment 2 Michael Catanzaro 2015-12-09 13:00:04 UTC 
Review of attachment 317015 [details] [review]:

Also to gnome-3-18

::: lib/ephy-snapshot-service.c
@@ +404,3 @@
   GdkPixbuf *snapshot;
   GError *error = NULL;
+  CacheData* cache_data;

CacheData *cache_data;

@@ +644,3 @@
 {
   char *path;
+  CacheData* cache_data;

Ditto

@@ +712,3 @@
 {
   char *path;
+  CacheData* cache_data;

Ditto
Comment 3 Michael Catanzaro 2015-12-09 13:00:05 UTC 
Review of attachment 317015 [details] [review]:

Also to gnome-3-18

::: lib/ephy-snapshot-service.c
@@ +404,3 @@
   GdkPixbuf *snapshot;
   GError *error = NULL;
+  CacheData* cache_data;

CacheData *cache_data;

@@ +644,3 @@
 {
   char *path;
+  CacheData* cache_data;

Ditto

@@ +712,3 @@
 {
   char *path;
+  CacheData* cache_data;

Ditto
Comment 4 Claudio Saavedra 2015-12-09 13:08:28 UTC 
Attachment 317015 [details] pushed as c988578 - snapshot-service: do not update cache table from other threads
Comment 5 Claudio Saavedra 2015-12-09 13:11:23 UTC 
*** Bug 759234 has been marked as a duplicate of this bug. ***