After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759217 - -Shuffle/Repeat Off option from the player section not shuffling the songs
-Shuffle/Repeat Off option from the player section not shuffling the songs
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: Spanish [es]
GNOME 3.18
Other Linux
: Normal normal
: ---
Assigned To: gnome-es-list@gnome.org
gnome-es-list@gnome.org
Depends on:
Blocks:
 
 
Reported: 2015-12-09 01:02 UTC by Javier Puiggros Vogel
Modified: 2016-01-11 16:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PlayerToolbar: Add some translator comments (2.86 KB, patch)
2016-01-08 14:26 UTC, Michael Catanzaro
committed Details | Review
Better attempt to add a translator comment (923 bytes, patch)
2016-01-08 15:31 UTC, Michael Catanzaro
reviewed Details | Review

Description Javier Puiggros Vogel 2015-12-09 01:02:58 UTC
When playing music in song's view, if I choose 'mix dont repeat' option from the player section It didn't random the songs and start strait with the list.
Comment 1 darkxst 2015-12-09 02:31:19 UTC
This seems to just be an incorrect translation. Shuffle/Repeat Off  effectively means "Shuffle off and Repeat off".
So the behaviour you describe is correct, songs should not be random with that option.  The Spanish string for that option needs to be changed to something less confusing!
Comment 2 Daniel Mustieles 2016-01-08 07:49:58 UTC
Hi,

The string has been fixed in both 3.18 and master branches, so it should be available in the next version of the package in your distro.

Also, maybe the original string might be a bit confusing for translators... could you consider to add a comment to it, to clarify it means to disable both shuffle and repeat functions?

Thanks!
Comment 3 Michael Catanzaro 2016-01-08 14:25:48 UTC
The following fix has been pushed:
8aff25d PlayerToolbar: Add some translator comments
Comment 4 Michael Catanzaro 2016-01-08 14:26:00 UTC
Created attachment 318496 [details] [review]
PlayerToolbar: Add some translator comments
Comment 5 Piotr Drąg 2016-01-08 15:10:36 UTC
This way of adding translator comments doesn't work in .ui files. You need to add comments="" attributes.
Comment 6 Michael Catanzaro 2016-01-08 15:29:02 UTC
Huh, I wonder how many .ui files I've messed up over the years. :)
Comment 7 Michael Catanzaro 2016-01-08 15:31:32 UTC
Created attachment 318507 [details] [review]
Better attempt to add a translator comment
Comment 8 Piotr Drąg 2016-01-09 13:11:39 UTC
Review of attachment 318507 [details] [review]:

Yes, this is the correct way to do it. :)
Comment 9 Daniel Mustieles 2016-01-11 14:30:08 UTC
Thanks for taking care of this! :)