After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759215 - [PATCH] Update files for Vala 0.32.
[PATCH] Update files for Vala 0.32.
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
: 758895 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-12-09 00:01 UTC by Yannick Inizan
Modified: 2015-12-22 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Update files for Vala 0.32. (1.15 KB, patch)
2015-12-09 00:01 UTC, Yannick Inizan
none Details | Review
[PATCH] Update files for Vala 0.32. (1.36 KB, patch)
2015-12-09 03:34 UTC, Yannick Inizan
none Details | Review
[ (1.36 KB, patch)
2015-12-09 03:42 UTC, Yannick Inizan
none Details | Review
[PATCH] Update files for Vala 0.32. (1.36 KB, patch)
2015-12-09 03:42 UTC, Yannick Inizan
committed Details | Review

Description Yannick Inizan 2015-12-09 00:01:47 UTC
Created attachment 316990 [details] [review]
[PATCH] Update files for Vala 0.32.

Update files for latest git version of vala
Comment 1 Christian Hergert 2015-12-09 00:29:14 UTC
Since we can still work on Vala 0.30, I'd like to see this support 0.30 as fallback.
Comment 2 Yannick Inizan 2015-12-09 03:34:22 UTC
Created attachment 316997 [details] [review]
[PATCH] Update files for Vala 0.32.

Patch updated : if vala 0.32 wasn't found, check 0.30 presence.
Comment 3 Christian Hergert 2015-12-09 03:37:51 UTC
Review of attachment 316997 [details] [review]:

Fix the $have_libvala to match xno and then LGTM to push.

::: plugins/vala-pack/configure.ac
@@ +2,3 @@
+PKG_CHECK_MODULES(VALA, [libvala-0.32],[have_libvala=yes],[have_libvala=no])
+VALA_VERSION=0.32
+AS_IF([test $have_libvala = xno],[

missing an x. either x$have_libvala or $have_libvala = no
Comment 4 Yannick Inizan 2015-12-09 03:42:20 UTC
Created attachment 316998 [details] [review]
[
Comment 5 Yannick Inizan 2015-12-09 03:42:49 UTC
Created attachment 316999 [details] [review]
[PATCH] Update files for Vala 0.32.
Comment 6 Christian Hergert 2015-12-21 23:50:07 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 7 alex diavatis 2015-12-22 15:59:27 UTC
*** Bug 758895 has been marked as a duplicate of this bug. ***