After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759207 - cluttersink: Holds on resources in NULL state
cluttersink: Holds on resources in NULL state
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-08 19:45 UTC by Nicolas Dufresne (ndufresne)
Modified: 2015-12-10 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video-sink: Ensure uploaded frame are displayed (1.17 KB, patch)
2015-12-08 19:47 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review
video-sink: Cleanup on _stop rather then late dispose (2.08 KB, patch)
2015-12-08 19:48 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2015-12-08 19:45:42 UTC 
This is because data is cleared in dispose rather then in stop.
Comment 1 Nicolas Dufresne (ndufresne) 2015-12-08 19:47:30 UTC 
Created attachment 316972 [details] [review]
video-sink: Ensure uploaded frame are displayed

This is fixed by making the uploading source lower priority than
the redraws. This is important, as Texture2D upload on slow memory
system can take a lot of time. You still want your UI to be
responsive (being able to show controls, resize, etc.)
Comment 2 Nicolas Dufresne (ndufresne) 2015-12-08 19:48:08 UTC 
Comment on attachment 316972 [details] [review]
video-sink: Ensure uploaded frame are displayed

Wrong patch.
Comment 3 Nicolas Dufresne (ndufresne) 2015-12-08 19:48:24 UTC 
Created attachment 316973 [details] [review]
video-sink: Cleanup on _stop rather then late dispose

We need to cleanup all our run-time resources when we go back to
ready state. Otherwise we endup holding buffers in the renderers.
Comment 4 Lionel Landwerlin 2015-12-09 09:01:02 UTC 
Review of attachment 316973 [details] [review]:

Looks good.
Comment 5 Lionel Landwerlin 2015-12-10 14:42:05 UTC 
Review of attachment 316973 [details] [review]:

Pushed to 3.0 branch.