After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759191 - should use pkg-config for GL
should use pkg-config for GL
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
1.24.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-08 17:05 UTC by Daniel Stone
Modified: 2015-12-11 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Use the 'x11' pkg-config module to check for X11 (1.35 KB, patch)
2015-12-08 17:22 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Daniel Stone 2015-12-08 17:05:27 UTC 
The configure.ac checks for OpenGL/EGL/GLX/... don't pay any heed to the pkg-config setup. This breaks when you have PKG_CONFIG_PATH pointing to something with mesa, but it's not in CFLAGS/LDFLAGS/etc.

It would be nice if configure.ac checked this (and took it into account when checking for gl.h, glx.h, etc), and then pushes the result.

Mesa and Mali-6xx provide these pkg-config files, and they're already used by quite a few clients.
Comment 1 Emmanuele Bassi (:ebassi) 2015-12-08 17:21:55 UTC 
The only platform check in Clutter's configure.ac is actually wrong — we should be checking for X11 (and use pkg-config at that), not glx.h or glXCreateContext. We don't use GLX or EGL directly anyway — and Cogl already uses pkg-config to check for the 'gl' package.
Comment 2 Emmanuele Bassi (:ebassi) 2015-12-08 17:22:11 UTC 
Created attachment 316964 [details] [review]
build: Use the 'x11' pkg-config module to check for X11

Don't look at GLX headers or symbols; we don't use them anyway.
Comment 3 Daniel Stone 2015-12-08 17:24:12 UTC 
Heh, nice! LGTM.
Comment 4 Daniel Stone 2015-12-09 18:27:23 UTC 
Ah, and now that WebKit has built, I can even tell you that it works. Ship it!
Comment 5 Emmanuele Bassi (:ebassi) 2015-12-11 16:03:39 UTC 
Pushed attachment 316964 [details] [review] to master, will likely also cherry pick it for the stable branch.