After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759178 - Bump gstreamer version to 1.6.0
Bump gstreamer version to 1.6.0
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-08 13:53 UTC by Kalev Lember
Modified: 2015-12-08 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bump gstreamer version to 1.6.0 (5.35 KB, patch)
2015-12-08 13:53 UTC, Kalev Lember
committed Details | Review

Description Kalev Lember 2015-12-08 13:53:12 UTC
When we reworked the gstreamer missing plugin installation code during the 3.16 cycle, we ended up writing code targeting an unreleased gstreamer development version. Because of that, we couldn't rely on distros having it and had to go with ifdefs to support the older versions as well.

I think it should be fine to drop the ifdefs now that 1.6 has been out for a while.
Comment 1 Kalev Lember 2015-12-08 13:53:51 UTC
Created attachment 316940 [details] [review]
Bump gstreamer version to 1.6.0

This bumps the gstreamer minimum version to 1.6.0 and drops ifdefs for
supporting older versions.
Comment 2 Bastien Nocera 2015-12-08 14:57:40 UTC
Review of attachment 316940 [details] [review]:

Looks good, to commit to master.
Comment 3 Kalev Lember 2015-12-08 15:02:58 UTC
Attachment 316940 [details] pushed as 8298b27 - Bump gstreamer version to 1.6.0