After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759137 - processor: Passing a non-NULL rectangle to gegl_node_new_processor leads to a WARNING
processor: Passing a non-NULL rectangle to gegl_node_new_processor leads to a...
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: core
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-12-07 19:28 UTC by Debarshi Ray
Modified: 2016-02-03 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
processor: Fix construction with a non-NULL rectangle (904 bytes, patch)
2015-12-07 19:31 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-12-07 19:28:08 UTC
We need to ensure that the graph is prepared before we start processing it. Normally when you pass NULL to gegl_node_new_processor, the gegl_node_get_bounding_box call in gegl_processor_set_rectangle has the side-effect of doing just that. However, if you have passed a non-NULL rectangle during construction, the graph is unprepared and processing it leads to a WARNING from the gegl_node_get_cache call in gegl_processor_render.

(The workaround is to create the processor with NULL and use a separate gegl_processor_set_rectangle call to set the rectangle.)
Comment 1 Debarshi Ray 2015-12-07 19:31:48 UTC
Created attachment 316901 [details] [review]
processor: Fix construction with a non-NULL rectangle
Comment 2 Debarshi Ray 2016-02-03 12:23:05 UTC
I am sufficiently confident about this one, so I am pushing it. Please let me know if it breaks anything.
Comment 3 Debarshi Ray 2016-02-03 12:25:07 UTC
Comment on attachment 316901 [details] [review]
processor: Fix construction with a non-NULL rectangle

commit 91b217d4e8f57a1204e5793e3aa66be6fac18299
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Dec 7 20:29:46 2015 +0100

    processor: Fix construction with a non-NULL rectangle
    
    Ensure that the graph is prepared whenever a new GeglNode is set.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759137