After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759122 - [review] lr/import-export: Add import and export capability
[review] lr/import-export: Add import and export capability
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openswan (deprecated)
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-07 13:44 UTC by Lubomir Rintel
Modified: 2015-12-16 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2015-12-07 13:44:41 UTC 
84866b5 properties: add connection import capability
092a273 properties: add connection export capability
6b144d9 common: don't use uuid for name when exporting the connection
041cc56 common: never write "(null)" for user name
653147e common: split out the connection writer from service
808a8d9 all: recognize the openswan VPN service name as well
84e57d6 all: vpn service name and bus name are different things

https://git.gnome.org/browse/network-manager-libreswan/log/?h=lr/import-export
Comment 1 Beniamino Galvani 2015-12-11 13:10:08 UTC 
> properties: add connection import capability

		if (g_str_has_prefix (str, "conn ")) {
+                       g_object_set (s_con, NM_SETTING_CONNECTION_ID, &str[5], NULL);
+               } else if (g_str_has_prefix (str, "leftid=@")) {
+                       nm_setting_vpn_add_data_item (s_vpn, NM_LIBRESWAN_LEFTID, &str[8]);

Braces are not needed for single-statement blocks. Otherwise LGTM.
Comment 2 Jiri Klimes 2015-12-14 08:36:24 UTC 
> common: never write "(null)" for user name

+	if (props_username && strlen (props_username))
Lets use
if (props_username && *props_username)

and similar for
+	else if (default_username && strlen (default_username))

Otherwise LGTM.