After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759117 - polari window grows over time at each restart
polari window grows over time at each restart
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-07 12:13 UTC by Olivier Fourdan
Modified: 2016-01-08 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mainWindow: fix growth at each restart (1.26 KB, patch)
2015-12-07 12:15 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2015-12-07 12:13:49 UTC 
gtk+ 3.19.x will compensate for client-side decorations in set_default_size() and get_size() but Polari uses the requisition size which includes the client-side decorations.
    
As a result, on exit, the window-size saved in gsettings includes the size of the client-side decorations, and on next restart, Polari's main window will end up being larger than previously.
Comment 1 Olivier Fourdan 2015-12-07 12:15:35 UTC 
Created attachment 316876 [details] [review]
mainWindow: fix growth at each restart

Proposed patch to fix the issue.
Comment 2 Florian Müllner 2015-12-11 12:06:06 UTC 
Review of attachment 316876 [details] [review]:

Sure.

The current code is following our current recommendations on that topic[0], so we probably want to update those as well ...

[0] https://wiki.gnome.org/HowDoI/SaveWindowState
Comment 3 Olivier Fourdan 2016-01-08 12:09:10 UTC 
Comment on attachment 316876 [details] [review]
mainWindow: fix growth at each restart

attachment 316876 [details] [review] pushed as commit 4314b20 mainWindow: fix growth at each restart