After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759109 - metrolyrics: fix parser after metrolyrics changes
metrolyrics: fix parser after metrolyrics changes
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-07 07:22 UTC by Victor Toso
Modified: 2015-12-07 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
metrolyrics: fix parser after metrolyrics changes (1.25 KB, patch)
2015-12-07 07:22 UTC, Victor Toso
committed Details | Review

Description Victor Toso 2015-12-07 07:22:32 UTC
Some changes on Metrolyrics again.
Comment 1 Victor Toso 2015-12-07 07:22:36 UTC
Created attachment 316866 [details] [review]
metrolyrics: fix parser after metrolyrics changes

Metrolyrics now include `class="js-lyric-text"` in the div for lyrics
and this patch just ignore it.

Also remove `<br>` noise that was introduced recently.
Comment 2 Bastien Nocera 2015-12-07 10:11:07 UTC
Review of attachment 316866 [details] [review]:

Looks good.
Comment 3 Victor Toso 2015-12-07 10:52:44 UTC
Attachment 316866 [details] pushed as 68ea116 - metrolyrics: fix parser after metrolyrics changes