GNOME Bugzilla – Bug 759088
Link searchbar with next and previous buttons
Last modified: 2015-12-08 13:30:19 UTC
In the preview mode, link the next/previous buttons with the search entry.
Created attachment 316840 [details] [review] preview: Link searchbar with next and previous buttons
Created attachment 316841 [details] [review] preview: Link searchbar with next and previous buttons
Created attachment 316842 [details] [review] preview: Remove raised style class
Review of attachment 316841 [details] [review]: Thanks Alessandro. This looks much better than what we have at the moment. Strangely, the bottom edge of the entry and the buttons are still not aligned for me. ::: src/preview.js @@ +945,3 @@ halign: Gtk.Align.CENTER}); + this._searchContainer.get_style_context().add_class('linked'); + this._searchContainer.get_style_context().add_class('raised'); I think 'raised' should be added to the prev/next buttons, not the entire searchContainer. eg., see OverviewSearchbar.
Review of attachment 316842 [details] [review]: ::: src/preview.js @@ -945,3 @@ halign: Gtk.Align.CENTER}); this._searchContainer.get_style_context().add_class('linked'); - this._searchContainer.get_style_context().add_class('raised'); Why? We are using it in OverviewSearchbar too. If there is a general recommendation against 'raised' then maybe we should remove it from there too?
(In reply to Debarshi Ray from comment #5) > Review of attachment 316842 [details] [review] [review]: > > ::: src/preview.js > @@ -945,3 @@ > halign: Gtk.Align.CENTER}); > this._searchContainer.get_style_context().add_class('linked'); > - this._searchContainer.get_style_context().add_class('raised'); > > Why? We are using it in OverviewSearchbar too. If there is a general > recommendation against 'raised' then maybe we should remove it from there > too? Ok, Cosimo confirmed that it is not needed in current Adwaita anymore.
I moved the patches around a bit to avoid adding 'raised' to the wrong widget.
Created attachment 316936 [details] [review] preview: Remove 'raised' style class
Created attachment 316937 [details] [review] preview: Link searchbar with next and previous buttons
Thanks for the lovely patches, Alessandro!