After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759088 - Link searchbar with next and previous buttons
Link searchbar with next and previous buttons
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-06 13:33 UTC by Alessandro Bono
Modified: 2015-12-08 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
preview: Link searchbar with next and previous buttons (2.46 KB, patch)
2015-12-06 13:38 UTC, Alessandro Bono
none Details | Review
preview: Link searchbar with next and previous buttons (2.52 KB, patch)
2015-12-06 13:42 UTC, Alessandro Bono
committed Details | Review
preview: Remove raised style class (943 bytes, patch)
2015-12-06 13:43 UTC, Alessandro Bono
reviewed Details | Review
preview: Remove 'raised' style class (882 bytes, patch)
2015-12-08 13:29 UTC, Debarshi Ray
committed Details | Review
preview: Link searchbar with next and previous buttons (2.41 KB, patch)
2015-12-08 13:29 UTC, Debarshi Ray
committed Details | Review

Description Alessandro Bono 2015-12-06 13:33:49 UTC
In the preview mode, link the next/previous buttons with the search entry.
Comment 1 Alessandro Bono 2015-12-06 13:38:05 UTC
Created attachment 316840 [details] [review]
preview: Link searchbar with next and previous buttons
Comment 2 Alessandro Bono 2015-12-06 13:42:23 UTC
Created attachment 316841 [details] [review]
preview: Link searchbar with next and previous buttons
Comment 3 Alessandro Bono 2015-12-06 13:43:24 UTC
Created attachment 316842 [details] [review]
preview: Remove raised style class
Comment 4 Debarshi Ray 2015-12-07 12:47:46 UTC
Review of attachment 316841 [details] [review]:

Thanks Alessandro. This looks much better than what we have at the moment. Strangely, the bottom edge of the entry and the buttons are still not aligned for me.

::: src/preview.js
@@ +945,3 @@
                                               halign: Gtk.Align.CENTER});
+        this._searchContainer.get_style_context().add_class('linked');
+        this._searchContainer.get_style_context().add_class('raised');

I think 'raised' should be added to the prev/next buttons, not the entire searchContainer. eg., see OverviewSearchbar.
Comment 5 Debarshi Ray 2015-12-07 12:49:10 UTC
Review of attachment 316842 [details] [review]:

::: src/preview.js
@@ -945,3 @@
                                               halign: Gtk.Align.CENTER});
         this._searchContainer.get_style_context().add_class('linked');
-        this._searchContainer.get_style_context().add_class('raised');

Why? We are using it in OverviewSearchbar too. If there is a general recommendation against 'raised' then maybe we should remove it from there too?
Comment 6 Debarshi Ray 2015-12-08 13:28:00 UTC
(In reply to Debarshi Ray from comment #5)
> Review of attachment 316842 [details] [review] [review]:
> 
> ::: src/preview.js
> @@ -945,3 @@
>                                                halign: Gtk.Align.CENTER});
>          this._searchContainer.get_style_context().add_class('linked');
> -        this._searchContainer.get_style_context().add_class('raised');
> 
> Why? We are using it in OverviewSearchbar too. If there is a general
> recommendation against 'raised' then maybe we should remove it from there
> too?

Ok, Cosimo confirmed that it is not needed in current Adwaita anymore.
Comment 7 Debarshi Ray 2015-12-08 13:28:40 UTC
I moved the patches around a bit to avoid adding 'raised' to the wrong widget.
Comment 8 Debarshi Ray 2015-12-08 13:29:12 UTC
Created attachment 316936 [details] [review]
preview: Remove 'raised' style class
Comment 9 Debarshi Ray 2015-12-08 13:29:48 UTC
Created attachment 316937 [details] [review]
preview: Link searchbar with next and previous buttons
Comment 10 Debarshi Ray 2015-12-08 13:30:08 UTC
Thanks for the lovely patches, Alessandro!