After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759027 - [review] refactor master/slave handling in NMDevice [th/device-master-slave-bgo759027]
[review] refactor master/slave handling in NMDevice [th/device-master-slave-b...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
1.0.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-12-04 13:36 UTC by Thomas Haller
Modified: 2015-12-05 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2015-12-04 13:36:40 UTC 
Please review
Comment 1 Thomas Haller 2015-12-04 17:30:45 UTC 
merged an early part of the branch after ACK by lrintel

http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=f740c5493691ac4f3c1a46c6d55ce07740c65bf4

The rest is still on review.
Comment 2 Dan Williams 2015-12-04 23:45:42 UTC 
LGTM as long as we're sure that the 'slaves' property gets exposed on D-Bus with the correct interface and that properties-changed notifications are sent out with the right interface too.  I'm pretty sure that's the case, but wouldn't hurt to check.
Comment 3 Thomas Haller 2015-12-05 18:55:51 UTC 
Commit "device: implement slave property in parent device class" works as expected in exposing the D-Bus property[1].


However, already on current master this (and other slave-related functionality) is broken as fall-out from devices-for-all. This branch doesn't fix that either.

As this branch is supposed to cleanup master/slave handling, I am going to merge it. I see little point in debugging (currently broken master) based on something that I anyway want to change.



[1] I verified that by cherry-picking the patch to an older, working version of master.



merged as: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=3acb6a366740086349aedca3a4e2b49709b77621