After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758959 - thetvdb: Force updating the show name
thetvdb: Force updating the show name
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-12-02 16:20 UTC by Bastien Nocera
Modified: 2015-12-09 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
thetvdb: Force updating the show name (2.02 KB, patch)
2015-12-02 16:20 UTC, Bastien Nocera 		committed Details | Review
tests: Test replacing TV show names (6.26 KB, patch)
2015-12-02 16:20 UTC, Bastien Nocera 		none Details | Review
Apply casefold for resolve_episodes and resolve_stress tests as well. (8.13 KB, patch)
2015-12-07 06:32 UTC, Victor Toso 		committed Details | Review

Description Bastien Nocera 2015-12-02 16:20:00 UTC 
.
Comment 1 Bastien Nocera 2015-12-02 16:20:16 UTC 
Created attachment 316667 [details] [review]
thetvdb: Force updating the show name

TheTVDB has localised show names, and will correct any missing
punctuation and casing that might be lost parsing filenames.
Comment 2 Bastien Nocera 2015-12-02 16:20:24 UTC 
Created attachment 316668 [details] [review]
tests: Test replacing TV show names

When using a casefolded TV show, check that the show got replaced
by the show name it would get from TheTVDB.
Comment 3 Victor Toso 2015-12-03 20:15:49 UTC 
Sorry, I did not have time to properly test it yet.
At first glance it is okay but when I quickly tried it seems to break the tests.

I'll take a look on it tomorrow.
Comment 4 Victor Toso 2015-12-07 06:32:19 UTC 
Created attachment 316865 [details] [review]
Apply casefold for resolve_episodes and resolve_stress tests as well.

Tests works now.


tests: Test replacing TV show names

When using a casefolded TV show, check that the show got replaced
by the show name it would get from TheTVDB.
Comment 5 Victor Toso 2015-12-07 06:34:14 UTC 
(In reply to Victor Toso from comment #4)
> Created attachment 316865 [details] [review] [review]
> Apply casefold for resolve_episodes and resolve_stress tests as well.

Errg. I forgot that first line is summary of attachment.
Patch is the same, I just --amend the same change in the other two tests.
Comment 6 Victor Toso 2015-12-07 06:34:35 UTC 
Review of attachment 316667 [details] [review]:

Looks good.
Comment 7 Victor Toso 2015-12-07 06:34:59 UTC 
Review of attachment 316865 [details] [review]:

Feel free to push if you agree with the changes.
Comment 8 Bastien Nocera 2015-12-09 11:05:59 UTC 
Attachment 316667 [details] pushed as aa4e593 - thetvdb: Force updating the show name