After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758945 - Disable inline display of TIFF images
Disable inline display of TIFF images
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
3.18.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2015-12-02 12:08 UTC by Pete Biggs
Modified: 2017-09-11 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (968 bytes, patch)
2017-09-07 17:30 UTC, Milan Crha
committed Details | Review

Description Pete Biggs 2015-12-02 12:08:22 UTC
A TIFF image received as an attachment (mime type image/tiff) doesn't display either inline or embedded in an HTML mail.  A "missing image" icon is shown in its place.

The images will display OK in an external viewer so the attachment is a valid TIFF image.

No errors are shown on STDOUT/STDERR.
Comment 1 Milan Crha 2015-12-03 17:10:36 UTC
Thanks for a bug report. Even if I fix the content type of the attachment by adding image/tif and image/tiff into [1], the webkit isn't able to show the tiff file, which is a pita. I can right-click the "missing image" icon and choose "copy image", then paste it into for example GIMP, and it is shown properly, thus it's something with the webkit not supporting tiff views for some reason (at least on my side).

Tom, do you know whether webkitgtk+ is able to show TIFF images inline, please?

[1] https://git.gnome.org/browse/evolution/tree/em-format/e-mail-parser-image.c#n40
Comment 2 Tomas Popela 2015-12-04 08:21:41 UTC
(In reply to Milan Crha from comment #1)
> Tom, do you know whether webkitgtk+ is able to show TIFF images inline,
> please?

It actually supports it (Firefox and Chromium does not). You can try to load [2] in GtkLauncher to try it for yourself. But it needs to be specially embedded in the page as you can see in [2]. We should probably go with example 6 or 7.

[2] - http://www.alternatiff.com/howtoembed.html
Comment 3 Tomas Popela 2015-12-04 09:14:05 UTC
(In reply to Tomas Popela from comment #2)
> (In reply to Milan Crha from comment #1)
> > Tom, do you know whether webkitgtk+ is able to show TIFF images inline,
> > please?
> 
> It actually supports it (Firefox and Chromium does not). You can try to load
> [2] in GtkLauncher to try it for yourself. But it needs to be specially
> embedded in the page as you can see in [2]. We should probably go with
> example 6 or 7.
> 
> [2] - http://www.alternatiff.com/howtoembed.html

And actually once we implement this it will stop to work in WebKit2 port as we want to disable the plugins there (you can try it in MiniBrowser by going to preferences, disable plugins there and reloading the page).
Comment 4 Milan Crha 2017-09-07 17:30:19 UTC
Created attachment 359369 [details] [review]
evo patch

for evolution;

As Tomas said, with WebKit2 the TIFF images cannot be shown inline, thus let's disable them for inline view and offer only Save and Open with... items.
Comment 5 Milan Crha 2017-09-11 14:31:13 UTC
Created commit f04d69a in evo master (3.27.1+)
Created commit acff211 in evo gnome-3-26 (3.26.1+)