After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758898 - Wrong info in age column due to 32bits overflow
Wrong info in age column due to 32bits overflow
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-01 12:41 UTC by Sebastien Bacher
Modified: 2015-12-02 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
that fixes the issue (1.01 KB, patch)
2015-12-01 12:44 UTC, Sebastien Bacher 		reviewed Details | Review

Description Sebastien Bacher 2015-12-01 12:41:20 UTC 
Using nautilus 3.18 on a 32 bits architecture, the days_ago computation trigers as gcc warning about int overflow and indeed the computation is wrong which leads to the age column always displaying the date not the week days
Comment 1 Sebastien Bacher 2015-12-01 12:44:18 UTC 
Created attachment 316591 [details] [review]
that fixes the issue
Comment 2 Carlos Soriano 2015-12-01 17:23:27 UTC 
Review of attachment 316591 [details] [review]:

Looks good thanks, although you will need to update the code to latest upstream changes.
Comment 3 Sebastien Bacher 2015-12-02 09:33:59 UTC 
> you will need to update the code to latest upstream changes.

what do you mean? I worked on git master I think (I've a recent checkout and git pull states I'm uptodate)
Comment 4 Carlos Soriano 2015-12-02 10:00:15 UTC 
(In reply to Sebastien Bacher from comment #3)
> > you will need to update the code to latest upstream changes.
> 
> what do you mean? I worked on git master I think (I've a recent checkout and
> git pull states I'm uptodate)

Oh you made me realize I didn't push a commit :)
Feel free to push this patch then and I will modify mine, thanks!
Comment 5 Carlos Soriano 2015-12-02 10:57:53 UTC 
Pushed with latests conflicts resolved. Thanks!
Comment 6 Sebastien Bacher 2015-12-02 12:51:39 UTC 
thanks
Comment 7 Sebastien Bacher 2015-12-02 12:53:17 UTC 
can you maybe backport to gnome-3-18 as well since it's a bugfix?
Comment 8 Carlos Soriano 2015-12-02 17:15:51 UTC 
sure