After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758882 - window: Don't destroy hardcoded window
window: Don't destroy hardcoded window
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-01 02:31 UTC by Matthias Clasen
Modified: 2015-12-01 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Don't destroy hardcoded window (1.31 KB, patch)
2015-12-01 02:31 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2015-12-01 02:31:05 UTC 
This commit changes the semantics of gtk_window_set_hardcoded_window
to not destroy the window on unrealize, but just drop the reference.
This is necessary to make it possible to set drag icons or windows
more than once on a drag context, which is something that can happen,
as seen e.g. in testentryicons.c.
Comment 1 Matthias Clasen 2015-12-01 02:31:14 UTC 
Created attachment 316567 [details] [review]
window: Don't destroy hardcoded window
Comment 2 Matthias Clasen 2015-12-01 03:01:50 UTC 
related to bug 748763
Comment 3 Matthias Clasen 2015-12-01 11:40:19 UTC 
there is more work needed on this; even with this patch, the warnings are gone but the drag icon still doesn't show up.
Comment 4 Matthias Clasen 2015-12-01 15:50:46 UTC 
lets drop this for now, the other approaches in bug 748763 are more promising.