GNOME Bugzilla – Bug 758855
media-check: check frames and not only headers
Last modified: 2015-12-04 23:20:28 UTC
At the moment, media-check is able to extract frame information from files but it never actually uses them when comparing in the tests. It is useful to have the frames compared to be capable to possible detect regressions in synchronization and timestamping. It doesn't take long to compare those frames information as we have tests that do playback of a few seconds of media, this is much shorter. I've been keeping my work on this here: http://cgit.freedesktop.org/~thiagoss/gst-devtools/log/?h=media-check-frames
Created attachment 316524 [details] [review] media-descriptor-writer: refactor getting the streamnode by a pad
Created attachment 316525 [details] [review] media-descriptor: check if frame data matches When comparing media descriptors, also check if the frames match
Created attachment 316526 [details] [review] media-check: enable 'full' for files which reference are also 'full' If the reference file has frames information, enable it automatically so that the comparison file also has frames to be used.
Review of attachment 316526 [details] [review]: OK
Review of attachment 316525 [details] [review]: Looks good.
Review of attachment 316524 [details] [review]: OK, please make sure we get the default testsuite fixed before merging :)
commit ae52807efdb7b3aa45528c5befa1374620092ff5 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Mon Nov 30 11:54:05 2015 -0300 media-check: enable 'full' for files which reference are also 'full' If the reference file has frames information, enable it automatically so that the comparison file also has frames to be used. https://bugzilla.gnome.org/show_bug.cgi?id=758855 commit ee7cb88d02a8e16402458b2c3e2ad97c3e510559 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Fri Nov 27 18:05:23 2015 -0300 media-descriptor: check if frame data matches When comparing media descriptors, also check if the frames match https://bugzilla.gnome.org/show_bug.cgi?id=758855 commit 84dd10b6284bc0b0f883e1f24ebe30ac555a539e Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Thu Nov 26 16:30:20 2015 -0300 media-descriptor-writer: refactor getting the streamnode by a pad https://bugzilla.gnome.org/show_bug.cgi?id=758855