GNOME Bugzilla – Bug 758845
wxi: update gstreamer-plugins* to 1.6.0
Last modified: 2016-01-14 12:57:52 UTC
Patches in a minute.
Created attachment 316512 [details] [review] wxi: update gstreamer1-plugins-base.wxi From 1.4.4 to 1.6.0 we have new headers to -base, they are: - gst/allocators/gstfdmemory.h - gst/rtp/gstrtp-enumtypes.h - gst/rtp/gstrtpdefs.h - gst/video/video-converter.h - gst/video/video-dither.h - gst/video/video-multiview.h - gst/video/video-resampler.h - gst/video/video-scaler.h
Created attachment 316513 [details] [review] wxi: update gstreamer1-plugins-bad-free.wxi Changes from 1.4.4 to 1.6.0: - files included: /bin/libgstadaptivedemux-1.0-0.dll /bin/libgstbadbase-1.0-0.dll /bin/libgstbadvideo-1.0-0.dll /include/gstreamer-1.0/gst/codecparsers/gstjpegparser.h /include/gstreamer-1.0/gst/gl/glprototypes/buffers.h /include/gstreamer-1.0/gst/gl/glprototypes/debug.h /include/gstreamer-1.0/gst/gl/glprototypes/gstgl_gles2compat.h /include/gstreamer-1.0/gst/gl/glprototypes/sync.h /include/gstreamer-1.0/gst/gl/glprototypes/vao.h /include/gstreamer-1.0/gst/gl/gstglbasebuffer.h /include/gstreamer-1.0/gst/gl/gstglbasefilter.h /include/gstreamer-1.0/gst/gl/gstgloverlaycompositor.h /include/gstreamer-1.0/gst/gl/gstglsyncmeta.h /include/gstreamer-1.0/gst/gl/gstgluploadmeta.h /include/gstreamer-1.0/gst/gl/gstglviewconvert.h /lib/gstreamer-1.0/include/gst/gl/gstglconfig.h /lib/gstreamer-1.0/libgstcompositor.dll /lib/gstreamer-1.0/libgstdtls.dll /lib/gstreamer-1.0/libgstrtpbad.dll /lib/gstreamer-1.0/libgstrtponvif.dll /lib/libgstadaptivedemux-1.0.dll.a /lib/libgstbadbase-1.0.dll.a /lib/libgstbadvideo-1.0.dll.a" - files removed: /include/gstreamer-1.0/gst/gl/gstglconfig.h /include/gstreamer-1.0/gst/gl/gstgles2.h /include/gstreamer-1.0/gst/gl/gstglmixer.h /include/gstreamer-1.0/gst/gl/gstglmixerpad.h /lib/libgstbasecamerabinsrc-1.0.la /lib/libgstcodecparsers-1.0.la /lib/libgstgl-1.0.la /lib/libgstinsertbin-1.0.la /lib/libgstmpegts-1.0.la /lib/libgstphotography-1.0.la /lib/libgsturidownloader-1.0.la"
It is worth to mention that for mingw version of gstreamer1-plugins-good, no changes were necessary to wxi
Oh, that's not correct. wxi files are include files for runtime MSI installer. The headers should be removed from all (gstreamer1) wxi.
Same with all the /lib/*.dll.a
Thanks for the review! (In reply to Marc-Andre Lureau from comment #4) > Oh, that's not correct. wxi files are include files for runtime MSI > installer. > > The headers should be removed from all (gstreamer1) wxi. Sure! (In reply to Marc-Andre Lureau from comment #5) > Same with all the /lib/*.dll.a No problem.
Created attachment 316516 [details] [review] nss.wxi: remove static libraries Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Created attachment 316518 [details] [review] gstreamer1: remove all the headers
Review of attachment 316518 [details] [review]: looks good, hopefully you verify virt-viewer.msi still builds before a release ;)
Review of attachment 316518 [details] [review]: I think you can remove .pc as well? gstreamer1.wxi:350: <File Id="fil6E57C6D4E9C414B0599BEA4F5E66153E" KeyPath="yes" Source="$(var.SourceDir)/lib/pkgconfig/gstreamer-1.0.pc"/> gstreamer1.wxi:353: <File Id="fil4A1528BA2727C6486DEC4EE383556E62" KeyPath="yes" Source="$(var.SourceDir)/lib/pkgconfig/gstreamer-base-1.0.pc"/> gstreamer1.wxi:356: <File Id="filA60FA32258F3BFD8D97713E8B2A93E30" KeyPath="yes" Source="$(var.SourceDir)/lib/pkgconfig/gstreamer-controller-1.0.pc"/> gstreamer1.wxi:359: <File Id="fil96E937B2AA7DB563DB3E63BED78F9163" KeyPath="yes" Source="$(var.SourceDir)/lib/pkgconfig/gstreamer-net-1.0.pc"/> and .dll.a too! gstreamer1.wxi:337: <File Id="fil377A6F093312B330ECF1BCED7EB248DC" KeyPath="yes" Source="$(var.SourceDir)/lib/libgstbase-1.0.dll.a"/> gstreamer1.wxi:340: <File Id="filF207C72D574C0022CE538EDE6F24E369" KeyPath="yes" Source="$(var.SourceDir)/lib/libgstcontroller-1.0.dll.a"/> gstreamer1.wxi:343: <File Id="fil8D3E5A6F186EAB60780048A46EFFF5CD" KeyPath="yes" Source="$(var.SourceDir)/lib/libgstnet-1.0.dll.a"/> gstreamer1.wxi:346: <File Id="filE872C0EE3395FE9D202DE70A15860D49" KeyPath="yes" Source="$(var.SourceDir)/lib/libgstreamer-1.0.dll.a"/> ?
Created attachment 316520 [details] [review] wxi: remove dll.a files from gstreamer1.wxi
Created attachment 316521 [details] [review] wxi: remove .pc files from gstreamer1.wxi
Created attachment 316530 [details] [review] wxi: remove headers from gstreamer1-plugins-base
Created attachment 316531 [details] [review] wxi: remove dll.a from gstreamer1-plugins-base
Created attachment 316532 [details] [review] wxi: remove pc from gstreamer1-plugins-base
Created attachment 316533 [details] [review] wxi: remove headers from gstreamer1-plugins-bad-free
Created attachment 316534 [details] [review] wxi: remove la & dll.a from gstreamer1-plugins-bad-free
Created attachment 316535 [details] [review] wxi: remove .pc from gstreamer1-plugins-bad-free
Review of attachment 316512 [details] [review]: No changes are needed for -plugins-base (you can see it was only headers..)
Review of attachment 316513 [details] [review]: I'll be updating this shortly in top of previous patches.
Created attachment 316537 [details] [review] wxi: update gstreamer1-plugins-bad-free from 1.4.4 to 1.6.0, the following files were included: /bin/libgstadaptivedemux-1.0-0.dll /bin/libgstbadbase-1.0-0.dll /bin/libgstbadvideo-1.0-0.dll /lib/gstreamer-1.0/libgstcompositor.dll /lib/gstreamer-1.0/libgstdtls.dll /lib/gstreamer-1.0/libgstrtpbad.dll /lib/gstreamer-1.0/libgstrtponvif.dll
Review of attachment 316520 [details] [review]: Looks good.
Review of attachment 316521 [details] [review]: Looks good.
Review of attachment 316516 [details] [review]: Looks good
Toso and Marc-André, all your patches look good. I will push them as soon as I finish my tests and do the release. Thanks for the patches!