GNOME Bugzilla – Bug 758833
File Operations requested from DBus should include a Timestamp to present the potential dialog
Last modified: 2021-06-18 15:56:04 UTC
When calling File operations dbus API methods such as CopyURIs, CopyFile or EmptyTrash a dialog might be presented, but in order to get that properly focused those APIs should require the event timestamp.
Created attachment 316509 [details] [review] Add *WithTimestamp dbus methods for file operations that might open a dialog The dialog should be presented with event time in order to be properly focused.
Comment on attachment 316509 [details] [review] Add *WithTimestamp dbus methods for file operations that might open a dialog Cosimo, can you take a look at this one? This look like overkill to me, but I'm not aware where this dbus methods are used or why is a problem if there is no timestamp if you are using nautilus at that time.
Review of attachment 316509 [details] [review]: I think a better way to do this might be to add another version of the interface (org.freedesktop.FileManager2) that has those methods with the new arguments - Nautilus could still expose both. What do you think, Marco?
> I think a better way to do this might be to add another version of the > interface (org.freedesktop.FileManager2) that has those methods with the new > arguments - Nautilus could still expose both. > What do you think, Marco? Yeah, I do agree. I did this to be a distro-patch initially, thus I didn't want to introduce a different interface, and I posted it here as a RFC mostly, but at this point I think it would be better to move these new methods to Filemanager2. Any argument that could be useful instead of just the timestamp? Maybe it would be more versatile to use an 'a{sv}' argument that would support the same parameters that GAppLaunchContext supports?
(In reply to Marco Trevisan (Treviño) from comment #4) > Any argument that could be useful instead of just the timestamp? Maybe it > would be more versatile to use an 'a{sv}' argument that would support the > same parameters that GAppLaunchContext supports? Yeah, that's a good idea. Let's make it an a{sv} instead, that is much more future-proof!
Marco, any plans to finish this?
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/504
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.