After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758826 - aacparse: Avoid over-skipping when checking LOAS config
aacparse: Avoid over-skipping when checking LOAS config
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-30 07:45 UTC by Edward Hervey
Modified: 2015-12-04 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
aacparse: Avoid over-skipping when checking LOAS config (1.48 KB, patch)
2015-11-30 07:45 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2015-11-30 07:45:33 UTC
See comment
Comment 1 Edward Hervey 2015-11-30 07:45:40 UTC
Created attachment 316503 [details] [review]
aacparse: Avoid over-skipping when checking LOAS config

There might be multiple LOAS config in a row in a full frame. The first
one might be a multi-layer config (which we can't properly parse yet)...
but then followed by a valid (single-layer) one.

The code was previously skipping whole frames (instead of just the LOAS
config we failed to read) resulting in multiple frames (seen up to 6s in
some situation) being dropped before finally getting the configuration.
Comment 2 Sebastian Dröge (slomo) 2015-12-02 15:56:26 UTC
Comment on attachment 316503 [details] [review]
aacparse: Avoid over-skipping when checking LOAS config

Makes sense, assuming that it's too difficult to just parse the size of the LOAS config. Note that skipping will cause the next buffer to be DISCONT iirc.
Comment 3 Edward Hervey 2015-12-04 10:57:14 UTC
commit 6888871d2acf3d4b6f219685602464b56f87cea6
Author: Edward Hervey <edward@centricular.com>
Date:   Mon Nov 30 08:42:35 2015 +0100

    aacparse: Avoid over-skipping when checking LOAS config
    
    There might be multiple LOAS config in a row in a full frame. The first
    one might be a multi-layer config (which we can't properly parse yet)...
    but then followed by a valid (single-layer) one.
    
    The code was previously skipping whole frames (instead of just the LOAS
    config we failed to read) resulting in multiple frames (seen up to 6s in
    some situation) being dropped before finally getting the configuration.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758826