After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758751 - [PATCH review] Avoid loosing signals due to org.freedesktop.DBus.Error.LimitsExceeded
[PATCH review] Avoid loosing signals due to org.freedesktop.DBus.Error.Limits...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-11-27 17:14 UTC by Lubomir Rintel
Modified: 2015-12-02 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A workaround (5.59 KB, text/plain)
2015-11-27 17:14 UTC, Lubomir Rintel 		Details

Description Lubomir Rintel 2015-11-27 17:14:15 UTC 
Created attachment 316410 [details]
A workaround

With 100 devices we're getting these:

========================================================================
GDBus-debug:Message:
  <<<< RECEIVED D-Bus message (251 bytes)
  Type:    error
  Flags:   no-reply-expected
  Version: 0
  Serial:  1254
  Headers:
    error-name -> 'org.freedesktop.DBus.Error.LimitsExceeded'
    reply-serial -> uint32 1631
    destination -> ':1.114'
    sender -> 'org.freedesktop.DBus'
    signature -> signature 's'
  Body: ('Connection ":1.114" is not allowed to add more match rules (increase limits in configuration file if required)',)
  UNIX File Descriptors:
    (none)

See: https://bugzilla.gnome.org/show_bug.cgi?id=758749
Comment 1 Thomas Haller 2015-11-28 17:24:10 UTC 
in the commit message, could you write:

Related: https://bugzilla.gnome.org/show_bug.cgi?id=758749

because this commit doesn't fix 758749 and there is a script to parse the commit message for bugs that are fixed by the commit. The "Related" keyword helps there.



Why do you want to allow 1024 signals unmodified before subscribing to all?
Can you not do it for all proxies and get rid of <limit name="max_match_rules_per_connection">2048</limit>.



Maybe
  nm_assert (!g_strcmp0 (g_dbus_proxy_get_name (proxy), "org.freedesktop.NetworkManager"));
to ensure we only handle expected senders.