After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758636 - Configure does not properly switch detect on/off X11 support
Configure does not properly switch detect on/off X11 support
Status: RESOLVED OBSOLETE
Product: gnote
Classification: Applications
Component: build
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-25 09:11 UTC by Gilles Dartiguelongue
Modified: 2016-03-28 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix X11 support configure switch (845 bytes, patch)
2015-11-25 09:11 UTC, Gilles Dartiguelongue
none Details | Review
Use AS_HELP_STRING + quoting (896 bytes, patch)
2015-11-25 09:11 UTC, Gilles Dartiguelongue
none Details | Review
Fix X11 support configure switch (1000 bytes, patch)
2015-11-25 09:26 UTC, Gilles Dartiguelongue
none Details | Review
Use AS_HELP_STRING + quoting (777 bytes, patch)
2015-11-25 09:27 UTC, Gilles Dartiguelongue
none Details | Review

Description Gilles Dartiguelongue 2015-11-25 09:11:03 UTC
Created attachment 316217 [details] [review]
Fix X11 support configure switch

Also, the switch should probably take the actual existence of the X11 library on the system into account as well. I can provide a more complete patch which moves all the pieces together if you wish.
Comment 1 Gilles Dartiguelongue 2015-11-25 09:11:36 UTC
Created attachment 316218 [details] [review]
Use AS_HELP_STRING + quoting

And a second patch for cosmetic of that option.
Comment 2 Gilles Dartiguelongue 2015-11-25 09:26:53 UTC
Created attachment 316219 [details] [review]
Fix X11 support configure switch

Made a mistake, 3rd parameter of AC_ARG_WITH/AC_ARG_ENABLE cannot be used like it is right now. This patch makes it right.
Comment 3 Gilles Dartiguelongue 2015-11-25 09:27:19 UTC
Created attachment 316220 [details] [review]
Use AS_HELP_STRING + quoting

Updated second patch.
Comment 4 Aurimas Černius 2016-03-28 15:08:17 UTC
X11 specific things have been removed, so this one is obsolete.