GNOME Bugzilla – Bug 758624
String suggestions and questions for help and GUI
Last modified: 2018-02-08 19:13:09 UTC
Hi, I am nearly finished with translating Orca's help to Swedish, so I come with some string suggestions and questions first. * For Live Regions: Niceness level "aggressive" should be "assertive" according to the GUI and what documentation I found on the standard. * c/preferences_gecko.page: "This option is also designed to prevent "chattiness" as there are many matches when you first begin typing string for which you are searching." Here it would sound nicer to me with "typing the string". * when you press <keyseq><key>Orca</key><key>F</key></keyseq>. Key name should be "<key>Orca Modifier</key>" * howto_text_setup.html.en: Missing navigation breadcrumbs. Something like "<link type="guide" xref="howto_setting_up_orca"/>" would make it much easier to navigate. * C/howto_tables.page "Setting Column Headers" "Set Row Headers" These two are next to each other and are essentially the same string, so both could use the form "Setting". * C/preferences_speech.page: The follow items will not be available "following" * C/preferences_table_navigation.page: The following option allows you to customize how <app>Orca</app> behaves when navigating within a table in <link xref="howto_structural_navigation">Structural-Navigation</link>-enabled applications. More than one option on that page, so "options" * C/howto_documents.page SayAll command "Say All" in all other strings. #: C/howto_key_bindings.page:23 C/howto_key_bindings.page:60 #: C/howto_keyboard_layout.page:45 C/howto_the_orca_modifier.page:53 msgid "" "Get into the <link xref=\"preferences\">Orca Preferences</link> dialog by " "pressing <keyseq><key>Orca Modifier</key><key>Space</key></keyseq>." #: C/howto_key_bindings.page:92 C/howto_key_bindings.page:114 msgid "" "Get into the <link xref=\"preferences\">Orca Preferences</link> dialog by " "pressing <keyseq><key>Orca Modifier</key><key>Space</key> </keyseq>." Only a space keeps these apart. The two occurrences in C/howto_key_bindings.page could be changed so there aren't two identical strings to translate. * "unicode" could be capitalized as "Unicode" (2 occurrences) * "<app>Orca's</app>" is written "<app>Orca</app>'s" in most strings, the three occurrences of the former could be replaced as well for consistency. Will send in a patch for the above mentioned things. Apart from that I have some string questions that arose during translation: * In C/preferences_general.page there are elements in "info" tags that I wonder how they are used, I can't find those in the resulting html file created from yelp-tools. (The strings in question start with "Preferences dialog box option...") * In C/commands_braille.page: "Review bottom left: Bottom Right" Is there a "Bottom right" option for brlTTY? The orca GUI file mentions the button "Bottom Left", so I wonder if this is a string mistake in the help. ------------------ I conclude with some questions for the GUI: * As shortened role names are translated in orca, it would be nice to have a translator comment about where the full role names are translated (am I right in assuming it is in atk?) * src/orca/cmdnames.py: "Bookmark where am I with respect to current position." Is this connected to the "Where Am I" functionality? In other cases I think the word order "where I am" is more common when it is not a question. * in src/orca/braille_rolenames.py "NOTE for all the short braille words: they we strive to keep them around three characters" Here "they" can be removed. Regards, Anders Jonsson
Created attachment 316207 [details] [review] Some fixups for greater consistency This patch fixes all except the five last points in the bug report.
Thanks! In the middle of something else, but let me answer your questions: 1. It looks like they were part of the original commit, nearly 5 years ago. So my best guess is that I read in some Mallard docs somewhere that having those things present would be good should I (or anyone else) wish to pull in content using Mallard magic. 2. From a quick grep through the code in Orca and docs in brlapi, it looks like a mistake in the docs. 3. Yes, you are right. https://git.gnome.org/browse/atk/tree/po/POTFILES.in 4. It is -- or rather was -- connected to the "Where Am I" functionality. It was never clear to me why we had the bookmark-whereami feature. See https://git.gnome.org/browse/orca/commit/?id=61509e3ab9b. I missed removing the cmdname. Sorry! 5. Indeed. What is the question? Apologies for all the mistakes in the docs, and thanks for all your work both in translating them and correcting them.
(In reply to Joanmarie Diggs (IRC: joanie) from comment #2) > Thanks! In the middle of something else, but let me answer your questions: > Thank you for your answers, all seems clear to me now. > > 5. Indeed. What is the question? > Ah, that one was not a question. The only reason I omitted it from the patch was that I wanted to make one patch purely for the help files. I can send in another patch for that, or you could fix it next time you touch the code. Your call on that one. > Apologies for all the mistakes in the docs, and thanks for all your work > both in translating them and correcting them. If anything I found it to be have a quite high standard for such a large amount of text. But the beauty of having source readily available is that good can always become even better.
I found one minor inconsistency with the recent string additions between GUI and help, so I'll mention that one here as well. In the GUI there are added 3 strings starting with "Speak full row in...", but when they are mentioned in the help they are written as "Read full row in..." instead.
Comment on attachment 316207 [details] [review] Some fixups for greater consistency I'm still waiting for the infrastructure to fully come back up, but I've got the patch committed locally and will include it when I'm able to push changes again. Thanks!