GNOME Bugzilla – Bug 758614
Support at least glib 2.34
Last modified: 2015-11-25 10:05:34 UTC
Created attachment 316196 [details] [review] Patch to work with at least glib 2.34 If g_type_init is not called in certain circumstances, the app needing to call it will not work. I found this to be the case with nm-dhcp-helper, but not sure if there are others (I dont fully exercise all NM capabilities). Also, g_unix_signal_add does not allow SIGUSR1 and SIGUSR2 before 2.36, and thus causes a runtime failure for 2.34 (though NM will compile fine). There's a good chance that this could lower support to less than 2.34, but I've not tested with anything previous.
(In reply to Glenn Washburn from comment #0) > Created attachment 316196 [details] [review] [review] > Patch to work with at least glib 2.34 > > If g_type_init is not called in certain circumstances, the app needing to > call it will not work. I found this to be the case with nm-dhcp-helper, but > not sure if there are others (I dont fully exercise all NM capabilities). Thanks for finding this. If there are other places, it would be a bug (and there are no such bugs known). Applied this part of the patch: master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=7a97d1694479f038277be522cdb6969eb25e40f2 nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=061b7bbde855146019aec189f76ddceec28bcb5b > Also, g_unix_signal_add does not allow SIGUSR1 and SIGUSR2 before 2.36, and > thus causes a runtime failure for 2.34 (though NM will compile fine). > > There's a good chance that this could lower support to less than 2.34, but > I've not tested with anything previous. I changed that part of your patched to do a runtime-check and to log a warning. master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8aab22fe4545f69a278351f990ccd021f16e25ff nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=be8619261d90026a4ee6840c9ee05666c6eb8557 Thank you